Changeset 37971 in webkit
- Timestamp:
- Oct 29, 2008 3:44:22 AM (16 years ago)
- Location:
- trunk
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r37969 r37971 1 2008-10-29 Alexey Proskuryakov <ap@webkit.org> 2 3 Reviewed by Darin Adler. 4 5 https://bugs.webkit.org/show_bug.cgi?id=21921 6 MessagePort messages are dispatched to documents that are not fully active 7 8 * fast/events/message-port-inactive-document.html: Protect the document from being 9 destructed in a working way (a global variable named "document" didn't do the trick due 10 to its name). 11 1 12 2008-10-29 Alexey Proskuryakov <ap@webkit.org> 2 13 -
trunk/LayoutTests/fast/events/message-port-inactive-document.html
r36891 r37971 23 23 } 24 24 25 var document;25 var otherDocument; 26 26 var mainPort; 27 27 28 28 function test() 29 29 { 30 document = window.frames[0].document;30 otherDocument = window.frames[0].document; 31 31 var channel = new MessageChannel; 32 32 window.frames[0].postMessage("msg", channel.port2, "*"); -
trunk/WebCore/ChangeLog
r37969 r37971 1 2008-10-29 Alexey Proskuryakov <ap@webkit.org> 2 3 Reviewed by Darin Adler. 4 5 https://bugs.webkit.org/show_bug.cgi?id=21921 6 MessagePort messages are dispatched to documents that are not fully active 7 8 Covered by corrected fast/events/message-port-inactive-document.html 9 10 * bindings/js/JSEventListener.cpp: 11 (WebCore::JSAbstractEventListener::handleEvent): Don't dispatch messages to contexts 12 that are not fully active. 13 1 14 2008-10-29 Alexey Proskuryakov <ap@webkit.org> 2 15 -
trunk/WebCore/bindings/js/JSEventListener.cpp
r37956 r37971 62 62 if (!frame) 63 63 return; 64 // The window must still be active in its frame. See <https://bugs.webkit.org/show_bug.cgi?id=21921>. 65 // FIXME: A better fix for this may be to change DMOWindow::frame() to not return a frame the detached window used to be in. 66 if (frame->domWindow() != window->impl()) 67 return; 64 68 ScriptController* script = frame->script(); 65 69 if (!script->isEnabled() || script->isPaused())
Note: See TracChangeset
for help on using the changeset viewer.