Changeset 38190 in webkit

Timestamp:

Nov 6, 2008 11:30:34 AM (16 years ago)

Author:

Simon Hausmann

Message:

2008-11-06 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22107

Bug uncovered during RVCT port in functions not used. get_lt() and
get_gt() takes only one argument - remove second argument where
applicable.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• wtf/AVLTree.h (modified) (4 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-11-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
+
+        Reviewed by Darin Adler.
+
+        https://bugs.webkit.org/show_bug.cgi?id=22107
+
+        Bug uncovered during RVCT port in functions not used. get_lt() and
+        get_gt() takes only one argument - remove second argument where
+        applicable.
+
+        * wtf/AVLTree.h:
+        (JSC::AVLTree::remove): Remove second argument of get_lt/get_gt().
+        (JSC::AVLTree::subst): Ditto.
+
 2008-11-06  Alp Toker  <alp@nuanti.com>
 

trunk/JavaScriptCore/wtf/AVLTree.h

@@ -823 +823 @@
 
         // Get the handle of the opposite child, which may not be null.
-        child = cmp > 0 ? get_lt(h, false) : get_gt(h, false);
+        child = cmp > 0 ? get_lt(h) : get_gt(h);
     }
 
@@ -842 +842 @@
     if (h != rm) {
         // Poke in the replacement for the node to be removed.
-        set_lt(h, get_lt(rm, false));
-        set_gt(h, get_gt(rm, false));
+        set_lt(h, get_lt(rm));
+        set_gt(h, get_gt(rm));
         set_bf(h, get_bf(rm));
         if (parent_rm == null())
@@ -935 +935 @@
 
     /* Copy tree housekeeping fields from node in tree to new node. */
-    set_lt(new_node, get_lt(h, false));
-    set_gt(new_node, get_gt(h, false));
+    set_lt(new_node, get_lt(h));
+    set_gt(new_node, get_gt(h));
     set_bf(new_node, get_bf(h));
 
@@ -953 +953 @@
 }
 
-
 }