Changeset 38782 in webkit

Timestamp:

Nov 26, 2008 3:31:27 AM (15 years ago)

Author:

jmalonzo@webkit.org

Message:

2008-11-26 Kalle Vahlman <​kalle.vahlman@movial.com>

Reviewed by Darin Adler. Landed by Jan Alonzo.

Bison versions under 2.2 produce crashing CSSGrammar code for ARM
​https://bugs.webkit.org/show_bug.cgi?id=22456

Check for bison version 2.2 or greater on ARM. Earlier versions produce
code that crashes on ARM devices.

• configure.ac:

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• configure.ac (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2008-11-26  Kalle Vahlman  <kalle.vahlman@movial.com>
+
+        Reviewed by Darin Adler. Landed by Jan Alonzo.
+
+        Bison versions under 2.2 produce crashing CSSGrammar code for ARM
+        https://bugs.webkit.org/show_bug.cgi?id=22456
+
+        Check for bison version 2.2 or greater on ARM. Earlier versions produce
+        code that crashes on ARM devices.
+
+        * configure.ac:
+
 2008-11-25  Holger Hans Peter Freyther  <zecke@selfish.org>
 

trunk/configure.ac

@@ -100 +100 @@
 if test -z "$BISON"; then
    AC_MSG_ERROR([You need the 'bison' parser generator to compile WebKit])
+else
+    case "$target_cpu" in
+        arm)
+            BISON_VERSION=`$BISON --version | head -1 | sed 's,.*\ \([0-9]*\.[0-9]*\)$,\1,'`
+            AX_COMPARE_VERSION([2.2],[gt],[$BISON_VERSION],
+                AC_MSG_ERROR([You need at least version 2.2 of the 'bison' parser generator to compile WebKit correctly for ARM]))
+        ;;
+        *) ;;
+    esac
 fi