Changeset 39201 in webkit
- Timestamp:
- Dec 11, 2008 2:09:50 AM (15 years ago)
- Location:
- trunk
- Files:
-
- 13 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebCore/ChangeLog
r39200 r39201 1 2008-12-08 Tor Arne Vestbø <tavestbo@trolltech.com> 2 3 Reviewed by Darin Adler and Holger Freyther. 4 5 Make Widget::frameRectsChanged() and overrides non-const 6 7 This will hopefully allow us to get rid of some of the mutables in 8 the classes that react to the callback by changing their own state. 9 10 * platform/ScrollView.cpp: 11 (WebCore::ScrollView::frameRectsChanged): 12 * platform/ScrollView.h: 13 * platform/Widget.h: 14 (WebCore::Widget::frameRectsChanged): 15 * platform/gtk/ScrollbarGtk.cpp: Remove non-const version since 16 this was more complex and did the same thing, changed const of 17 the leftover frameRectsChanged() method. 18 (ScrollbarGtk::frameRectsChanged): 19 * platform/gtk/ScrollbarGtk.h: 20 * plugins/PluginView.cpp: 21 (WebCore::PluginView::frameRectsChanged): 22 * plugins/PluginView.h: 23 1 24 2008-12-11 Holger Hans Peter Freyther <zecke@selfish.org> 2 25 -
trunk/WebCore/platform/ScrollView.cpp
r39103 r39201 590 590 } 591 591 592 void ScrollView::frameRectsChanged() const592 void ScrollView::frameRectsChanged() 593 593 { 594 594 if (platformWidget()) -
trunk/WebCore/platform/ScrollView.h
r39103 r39201 169 169 170 170 // Called when our frame rect changes (or the rect/scroll position of an ancestor changes). 171 virtual void frameRectsChanged() const;171 virtual void frameRectsChanged(); 172 172 173 173 // Widget override to update our scrollbars and notify our contents of the resize. -
trunk/WebCore/platform/Widget.h
r37599 r39201 169 169 IntRect convertFromContainingWindow(const IntRect&) const; 170 170 171 virtual void frameRectsChanged() const{}171 virtual void frameRectsChanged() {} 172 172 173 173 #if PLATFORM(MAC) -
trunk/WebCore/platform/gtk/ScrollbarGtk.cpp
r37198 r39201 77 77 } 78 78 79 void ScrollbarGtk::frameRectsChanged() const79 void ScrollbarGtk::frameRectsChanged() 80 80 { 81 81 if (!parent() || !parent()->isScrollViewScrollbar(this)) … … 115 115 } 116 116 117 void ScrollbarGtk::frameRectsChanged()118 {119 if (!parent())120 return;121 122 ASSERT(parent()->isFrameView());123 124 FrameView* frameView = static_cast<FrameView*>(parent());125 IntRect windowRect = IntRect(frameView->contentsToWindow(frameRect().location()), frameRect().size());126 127 IntSize sz = frameRect().size();128 sz.clampNegativeToZero();129 130 GtkAllocation allocation = { windowRect.x(), windowRect.y(), sz.width(), sz.height() };131 gtk_widget_size_allocate(platformWidget(), &allocation);132 }133 134 117 void ScrollbarGtk::gtkValueChanged(GtkAdjustment*, ScrollbarGtk* that) 135 118 { -
trunk/WebCore/platform/gtk/ScrollbarGtk.h
r37198 r39201 49 49 virtual void setEnabled(bool); 50 50 51 virtual void frameRectsChanged() const;51 virtual void frameRectsChanged(); 52 52 53 53 protected: … … 56 56 virtual void updateThumbPosition(); 57 57 virtual void updateThumbProportion(); 58 virtual void frameRectsChanged();59 58 60 59 private: -
trunk/WebCore/plugins/PluginView.cpp
r38614 r39201 133 133 } 134 134 135 void PluginView::frameRectsChanged() const135 void PluginView::frameRectsChanged() 136 136 { 137 137 updatePluginWidget(); -
trunk/WebCore/plugins/PluginView.h
r38371 r39201 148 148 // Widget functions 149 149 virtual void setFrameRect(const IntRect&); 150 virtual void frameRectsChanged() const;150 virtual void frameRectsChanged(); 151 151 virtual void setFocus(); 152 152 virtual void show(); -
trunk/WebKit/qt/ChangeLog
r39173 r39201 1 2008-12-08 Tor Arne Vestbø <tavestbo@trolltech.com> 2 3 Reviewed by Darin Adler and Holger Freyther. 4 5 Make Widget::frameRectsChanged() and overrides non-const 6 7 This will hopefully allow us to get rid of some of the mutables in 8 the classes that react to the callback by changing their own state. 9 10 * WebCoreSupport/FrameLoaderClientQt.cpp: 11 (WebCore::): 12 1 13 2008-12-10 Holger Hans Peter Freyther <zecke@selfish.org> 2 14 -
trunk/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp
r38758 r39201 1000 1000 platformWidget()->update(r); 1001 1001 } 1002 virtual void frameRectsChanged() const1002 virtual void frameRectsChanged() 1003 1003 { 1004 1004 if (!platformWidget()) -
trunk/WebKit/win/ChangeLog
r39152 r39201 1 2008-12-08 Tor Arne Vestbø <tavestbo@trolltech.com> 2 3 Reviewed by Darin Adler and Holger Freyther. 4 5 Make Widget::frameRectsChanged() and overrides non-const 6 7 This will hopefully allow us to get rid of some of the mutables in 8 the classes that react to the callback by changing their own state. 9 10 * WebCoreSupport/EmbeddedWidget.cpp: 11 (EmbeddedWidget::frameRectsChanged): 12 * WebCoreSupport/EmbeddedWidget.h: 13 1 14 2008-12-09 Brett Wilson <brettw@chromium.org> 2 15 -
trunk/WebKit/win/WebCoreSupport/EmbeddedWidget.cpp
r37223 r39201 85 85 } 86 86 87 void EmbeddedWidget::frameRectsChanged() const87 void EmbeddedWidget::frameRectsChanged() 88 88 { 89 89 if (!parent()) -
trunk/WebKit/win/WebCoreSupport/EmbeddedWidget.h
r37223 r39201 57 57 virtual void invalidateRect(const WebCore::IntRect&); 58 58 virtual void setFrameRect(const WebCore::IntRect&); 59 virtual void frameRectsChanged() const;59 virtual void frameRectsChanged(); 60 60 virtual void setFocus(); 61 61 virtual void show();
Note: See TracChangeset
for help on using the changeset viewer.