Changeset 39882 in webkit

Timestamp:

Jan 13, 2009 5:44:28 PM (15 years ago)

Author:

Beth Dakin

Message:

JavaScriptCore:

2009-01-13 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler and Oliver Hunt.

<rdar://problem/6489314> REGRESSION: Business widget's front side
fails to render correctly when flipping widget

The problem here is that parseInt was parsing NaN as 0. This patch
corrects that by parsing NaN as NaN. This matches our old behavior
and Firefox.

• runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncParseInt):

LayoutTests:

2009-01-13 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler and Oliver Hunt.

Updated test and results for <rdar://problem/6489314> REGRESSION:
Business widget's front side fails to render correctly when
flipping widget

parseInt(NaN) should be NaN.

• fast/js/numeric-conversion-expected.txt:
• fast/js/resources/numeric-conversion.js:

Location:

trunk

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp (modified) (1 diff)
• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/js/numeric-conversion-expected.txt (modified) (1 diff)
• LayoutTests/fast/js/resources/numeric-conversion.js (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2009-01-13  Beth Dakin  <bdakin@apple.com>
+
+        Reviewed by Darin Adler and Oliver Hunt.
+
+        <rdar://problem/6489314> REGRESSION: Business widget's front side 
+        fails to render correctly when flipping widget
+
+        The problem here is that parseInt was parsing NaN as 0. This patch 
+        corrects that by parsing NaN as NaN. This matches our old behavior 
+        and Firefox. 
+
+        * runtime/JSGlobalObjectFunctions.cpp:
+        (JSC::globalFuncParseInt):
+
 2009-01-13  Gavin Barraclough  <barraclough@apple.com>
 

trunk/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp

@@ -303 +303 @@
             return value;
         double d = value->uncheckedGetNumber();
-        if (!isfinite(d))
-            return js0();
-        return jsNumber(exec, floor(d));
+        if (isfinite(d))
+            return jsNumber(exec, floor(d));
+        if (isnan(d))
+            return jsNaN(&exec->globalData());
+        return js0();
     }
 

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-01-13  Beth Dakin  <bdakin@apple.com>
+
+        Reviewed by Darin Adler and Oliver Hunt.
+
+        Updated test and results for <rdar://problem/6489314> REGRESSION: 
+        Business widget's front side fails to render correctly when 
+        flipping widget
+
+        parseInt(NaN) should be NaN.
+        * fast/js/numeric-conversion-expected.txt:
+        * fast/js/resources/numeric-conversion.js:
+
 2009-01-13  Anders Carlsson  <andersca@apple.com>
 

trunk/LayoutTests/fast/js/numeric-conversion-expected.txt

@@ -18 +18 @@
 PASS parseInt('9007199254740992e2000').toString() is '9007199254740992'
 PASS parseInt('9007199254740992.0e2000').toString() is '9007199254740992'
-PASS parseInt(NaN) is 0
+PASS parseInt(NaN) is NaN
 PASS parseInt(-Infinity) is 0
 PASS parseInt(Infinity) is 0

trunk/LayoutTests/fast/js/resources/numeric-conversion.js

@@ -23 +23 @@
 shouldBe("parseInt('9007199254740992.0e2000').toString()", "'9007199254740992'");
 
-shouldBe("parseInt(NaN)", "0");
+shouldBe("parseInt(NaN)", "NaN");
 shouldBe("parseInt(-Infinity)", "0");
 shouldBe("parseInt(Infinity)", "0");