Changeset 40300 in webkit

Timestamp:

Jan 27, 2009 1:54:33 PM (15 years ago)

Author:

Simon Fraser

Message:

2009-01-27 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Flip the arguments of computeRectForRepaint() from

computeRectForRepaint(IntRect&, RenderBox* repaintContainer, bool)

to

computeRectForRepaint(RenderBox* repaintContainer, IntRect&, bool)

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderBox.cpp (modified) (2 diffs)
• rendering/RenderBox.h (modified) (1 diff)
• rendering/RenderForeignObject.cpp (modified) (1 diff)
• rendering/RenderForeignObject.h (modified) (1 diff)
• rendering/RenderInline.cpp (modified) (1 diff)
• rendering/RenderObject.cpp (modified) (2 diffs)
• rendering/RenderObject.h (modified) (1 diff)
• rendering/RenderReplaced.cpp (modified) (1 diff)
• rendering/RenderTableCell.cpp (modified) (2 diffs)
• rendering/RenderTableCell.h (modified) (1 diff)
• rendering/RenderView.cpp (modified) (1 diff)
• rendering/RenderView.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-01-27  Simon Fraser  <simon.fraser@apple.com>
+
+        Reviewed by Dave Hyatt
+
+        Flip the arguments of computeRectForRepaint() from
+            computeRectForRepaint(IntRect&, RenderBox* repaintContainer, bool)
+        to 
+            computeRectForRepaint(RenderBox* repaintContainer, IntRect&, bool)
+
+        * rendering/RenderBox.cpp:
+        (WebCore::RenderBox::clippedOverflowRectForRepaint):
+        (WebCore::RenderBox::computeRectForRepaint):
+        * rendering/RenderBox.h:
+        * rendering/RenderForeignObject.cpp:
+        (WebCore::RenderForeignObject::computeRectForRepaint):
+        * rendering/RenderForeignObject.h:
+        * rendering/RenderInline.cpp:
+        (WebCore::RenderInline::clippedOverflowRectForRepaint):
+        * rendering/RenderObject.cpp:
+        (WebCore::RenderObject::computeRectForRepaint):
+        * rendering/RenderObject.h:
+        (WebCore::RenderObject::computeAbsoluteRepaintRect):
+        * rendering/RenderReplaced.cpp:
+        (WebCore::RenderReplaced::clippedOverflowRectForRepaint):
+        * rendering/RenderTableCell.cpp:
+        (WebCore::RenderTableCell::clippedOverflowRectForRepaint):
+        (WebCore::RenderTableCell::computeRectForRepaint):
+        * rendering/RenderTableCell.h:
+        * rendering/RenderView.cpp:
+        (WebCore::RenderView::computeRectForRepaint):
+        * rendering/RenderView.h:
+
 2009-01-27  David Kilzer  <ddkilzer@apple.com>
 

trunk/WebCore/rendering/RenderBox.cpp

@@ -1567 +1567 @@
         }
     }
-    computeRectForRepaint(r, repaintContainer);
+    computeRectForRepaint(repaintContainer, r);
     return r;
 }
 
-void RenderBox::computeRectForRepaint(IntRect& rect, RenderBox* repaintContainer, bool fixed)
+void RenderBox::computeRectForRepaint(RenderBox* repaintContainer, IntRect& rect, bool fixed)
 {
     if (RenderView* v = view()) {
@@ -1652 +1652 @@
         rect.setLocation(topLeft);
     
-    o->computeRectForRepaint(rect, repaintContainer, fixed);
+    o->computeRectForRepaint(repaintContainer, rect, fixed);
 }
 

trunk/WebCore/rendering/RenderBox.h

@@ -208 +208 @@
 
     virtual IntRect clippedOverflowRectForRepaint(RenderBox* repaintContainer);
-    virtual void computeRectForRepaint(IntRect&, RenderBox* repaintContainer, bool fixed = false);
+    virtual void computeRectForRepaint(RenderBox* repaintContainer, IntRect&, bool fixed = false);
     IntSize offsetForPositionedInContainer(RenderObject*) const;
     virtual FloatQuad localToContainerQuad(const FloatQuad&, RenderBox* repaintContainer, bool fixed = false) const;

trunk/WebCore/rendering/RenderForeignObject.cpp

@@ -71 +71 @@
 }
 
-void RenderForeignObject::computeRectForRepaint(IntRect& rect, RenderBox* repaintContainer, bool fixed)
+void RenderForeignObject::computeRectForRepaint(RenderBox* repaintContainer, IntRect& rect, bool fixed)
 {
     TransformationMatrix transform = translationForAttributes() * localTransform();
     rect = transform.mapRect(rect);
 
-    RenderBlock::computeRectForRepaint(rect, repaintContainer, fixed);
+    RenderBlock::computeRectForRepaint(repaintContainer, rect, fixed);
 }
 

trunk/WebCore/rendering/RenderForeignObject.h

@@ -43 +43 @@
     virtual bool calculateLocalTransform();
 
-    virtual void computeRectForRepaint(IntRect&, RenderBox* repaintContainer, bool fixed = false);
+    virtual void computeRectForRepaint(RenderBox* repaintContainer, IntRect&, bool fixed = false);
     virtual bool requiresLayer() const { return false; }
     virtual void layout();

trunk/WebCore/rendering/RenderInline.cpp

@@ -441 +441 @@
     }
     ASSERT(repaintContainer != this);
-    cb->computeRectForRepaint(r, repaintContainer);
+    cb->computeRectForRepaint(repaintContainer, r);
 
     if (ow) {

trunk/WebCore/rendering/RenderObject.cpp

@@ -1831 +1831 @@
 }
 
-void RenderObject::computeRectForRepaint(IntRect& rect, RenderBox* repaintContainer, bool fixed)
+void RenderObject::computeRectForRepaint(RenderBox* repaintContainer, IntRect& rect, bool fixed)
 {
     if (repaintContainer == this)
@@ -1859 +1859 @@
         }
 
-        o->computeRectForRepaint(rect, repaintContainer, fixed);
+        o->computeRectForRepaint(repaintContainer, rect, fixed);
     }
 }

trunk/WebCore/rendering/RenderObject.h

@@ -607 +607 @@
     void computeAbsoluteRepaintRect(IntRect& r, bool fixed = false)
     {
-        return computeRectForRepaint(r, 0, fixed);
+        return computeRectForRepaint(0, r, fixed);
     }
     // Given a rect in the object's coordinate space, compute a rect suitable for repainting
     // that rect in the coordinate space of repaintContainer.
-    virtual void computeRectForRepaint(IntRect&, RenderBox* repaintContainer, bool fixed = false);
+    virtual void computeRectForRepaint(RenderBox* repaintContainer, IntRect&, bool fixed = false);
 
     virtual unsigned int length() const { return 1; }

trunk/WebCore/rendering/RenderReplaced.cpp

@@ -413 +413 @@
             r.inflate(style()->outlineSize());
     }
-    computeRectForRepaint(r, repaintContainer);
+    computeRectForRepaint(repaintContainer, r);
     return r;
 }

trunk/WebCore/rendering/RenderTableCell.cpp

@@ -202 +202 @@
         r.move(v->layoutDelta());
     }
-    computeRectForRepaint(r, repaintContainer);
+    computeRectForRepaint(repaintContainer, r);
     return r;
 }
 
-void RenderTableCell::computeRectForRepaint(IntRect& r, RenderBox* repaintContainer, bool fixed)
+void RenderTableCell::computeRectForRepaint(RenderBox* repaintContainer, IntRect& r, bool fixed)
 {
     if (repaintContainer == this)
@@ -214 +214 @@
     if ((!v || !v->layoutStateEnabled()) && parent())
         r.move(-parentBox()->x(), -parentBox()->y()); // Rows are in the same coordinate space, so don't add their offset in.
-    RenderBlock::computeRectForRepaint(r, repaintContainer, fixed);
+    RenderBlock::computeRectForRepaint(repaintContainer, r, fixed);
 }
 

trunk/WebCore/rendering/RenderTableCell.h

@@ -96 +96 @@
 
     virtual IntRect clippedOverflowRectForRepaint(RenderBox* repaintContainer);
-    virtual void computeRectForRepaint(IntRect&, RenderBox* repaintContainer, bool fixed = false);
+    virtual void computeRectForRepaint(RenderBox* repaintContainer, IntRect&, bool fixed = false);
     virtual FloatPoint localToAbsolute(FloatPoint localPoint = FloatPoint(), bool fixed = false, bool useTransforms = false) const;
     virtual FloatPoint absoluteToLocal(FloatPoint containerPoint, bool fixed = false, bool useTransforms = false) const;

trunk/WebCore/rendering/RenderView.cpp

@@ -241 +241 @@
 }
 
-void RenderView::computeRectForRepaint(IntRect& rect, RenderBox* repaintContainer, bool fixed)
+void RenderView::computeRectForRepaint(RenderBox* repaintContainer, IntRect& rect, bool fixed)
 {
     // If a container was specified, and was not 0 or the RenderView,

trunk/WebCore/rendering/RenderView.h

@@ -61 +61 @@
     virtual bool hasOverhangingFloats() { return false; }
 
-    virtual void computeRectForRepaint(IntRect&, RenderBox* repaintContainer, bool fixed = false);
+    virtual void computeRectForRepaint(RenderBox* repaintContainer, IntRect&, bool fixed = false);
     virtual void repaintViewRectangle(const IntRect&, bool immediate = false);