Changeset 40306 in webkit

Timestamp:

Jan 27, 2009 8:08:20 PM (15 years ago)

Author:

andersca@apple.com

Message:

2009-01-27 Anders Carlsson <​andersca@apple.com>

Reviewed by Oliver Hunt.

Fix two bugs with Core Animation based plug-ins.

1. The plug-in view was marked as opaque even though it's not. (This would leave garbage in the plug-in view).
2. The plug-in layer needs to have autoresizing turned on.

• Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView setLayer:]):

Location:

trunk/WebKit/mac

Files:

• ChangeLog (modified) (1 diff)
• Plugins/WebNetscapePluginView.mm (modified) (2 diffs)

trunk/WebKit/mac/ChangeLog

@@ +1 @@
+2009-01-27  Anders Carlsson  <andersca@apple.com>
+
+        Reviewed by Oliver Hunt.
+
+        Fix two bugs with Core Animation based plug-ins.
+        
+        1. The plug-in view was marked as opaque even though it's not. 
+           (This would leave garbage in the plug-in view).
+        2. The plug-in layer needs to have autoresizing turned on.
+        
+        * Plugins/WebNetscapePluginView.mm:
+        (-[WebNetscapePluginView setLayer:]):
+
 2009-01-27  Brady Eidson  <beidson@apple.com>
 

trunk/WebKit/mac/Plugins/WebNetscapePluginView.mm

@@ -1077 +1077 @@
 {
     [super setLayer:newLayer];
-    
-    if (_pluginLayer)
+
+    if (_pluginLayer) {
+        _pluginLayer.get().autoresizingMask = kCALayerWidthSizable | kCALayerHeightSizable;
         [newLayer addSublayer:_pluginLayer.get()];
+    }
 }
 #endif
@@ -1935 +1937 @@
     [self setNeedsDisplayInRect:NSMakeRect(invalidRect->left, invalidRect->top,
         (float)invalidRect->right - invalidRect->left, (float)invalidRect->bottom - invalidRect->top)];
-}
-
--(BOOL)isOpaque
-{
-    return YES;
 }