Changeset 40654 in webkit

Timestamp:

Feb 4, 2009 5:26:15 PM (15 years ago)

Author:

eric@webkit.org

Message:

Reviewed by George Staikos.

Reverse the meaning of the if check so that Android
(dpad devices) do not scroll on focus and normal platforms do
​http://trac.webkit.org/changeset/40647

This was caught by George Staikos, and I wrote the patch.

• dom/Element.cpp: (WebCore::Element::updateFocusAppearance):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Element.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-02-04  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by George Staikos.
+
+        Reverse the meaning of the if check so that Android
+        (dpad devices) do not scroll on focus and normal platforms do
+        http://trac.webkit.org/changeset/40647
+        
+        This was caught by George Staikos, and I wrote the patch.
+
+        * dom/Element.cpp:
+        (WebCore::Element::updateFocusAppearance):
+
 2009-02-04  David Hyatt  <hyatt@apple.com>
 

trunk/WebCore/dom/Element.cpp

@@ -1112 +1112 @@
             frame->revealSelection();
         }
-    } 
-#if ENABLE(DIRECTIONAL_PAD_NAVIGATION)
+    }
+    // FIXME: I'm not sure all devices will want this off, but this is
+    // currently turned off for Andriod.
+#if !ENABLE(DIRECTIONAL_PAD_NAVIGATION)
     else if (renderer() && !renderer()->isWidget())
         renderer()->enclosingLayer()->scrollRectToVisible(getRect());