Changeset 40707 in webkit

Timestamp:

Feb 5, 2009 9:37:07 PM (15 years ago)

Author:

Simon Fraser

Message:

2009-02-05 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

​https://bugs.webkit.org/show_bug.cgi?id=23362

If the WebHTMLView uses accelerated compositing, we need for force
the on-screen capture path and also force animations to start with -display
since the DRT window has autodisplay disabled.

• DumpRenderTree/mac/PixelDumpSupportMac.mm: (createBitmapContextFromWebView):

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/mac/PixelDumpSupportMac.mm (modified) (2 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-02-05  Simon Fraser  <simon.fraser@apple.com>
+
+        Reviewed by Dan Bernstein
+
+        https://bugs.webkit.org/show_bug.cgi?id=23362
+
+        If the WebHTMLView uses accelerated compositing, we need for force
+        the on-screen capture path and also force animations to start with -display
+        since the DRT window has autodisplay disabled.
+
+        * DumpRenderTree/mac/PixelDumpSupportMac.mm:
+        (createBitmapContextFromWebView):
+
 2009-02-03  miggilin  <mr.diggilin@gmail.com>
 

trunk/WebKitTools/DumpRenderTree/mac/PixelDumpSupportMac.mm

@@ -44 +44 @@
 #import <WebKit/WebDocumentPrivate.h>
 #import <WebKit/WebKit.h>
+#import <WebKit/WebHTMLViewPrivate.h>
 
 // To ensure pixel tests consistency, we need to always render in the same colorspace.
@@ -103 +104 @@
 PassRefPtr<BitmapContext> createBitmapContextFromWebView(bool onscreen, bool incrementalRepaint, bool sweepHorizontally, bool drawSelectionRect)
 {
+    // If the WebHTMLView uses accelerated compositing, we need for force the on-screen capture path
+    // and also force Core Animation to start its animations with -display since the DRT window has autodisplay disabled.
+    NSView* documentView = [[mainFrame frameView] documentView];
+    if ([documentView isKindOfClass:[WebHTMLView class]]) {
+        WebHTMLView* htmlView = (WebHTMLView*)documentView;
+        if ([htmlView respondsToSelector:@selector(_isUsingAcceleratedCompositing)] && [htmlView _isUsingAcceleratedCompositing]) {
+            [[htmlView window] display];
+            onscreen = YES;
+        }
+    }
+
     WebView* view = [mainFrame webView];
     NSSize webViewSize = [view frame].size;