Changeset 41209 in webkit


Ignore:
Timestamp:
Feb 24, 2009 10:18:17 PM (15 years ago)
Author:
Simon Fraser
Message:

2009-02-24 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson

​https://bugs.webkit.org/show_bug.cgi?id=15081

Make display:none work for applet, emebed and object elements
by calling rendererIsNeeded() on superclasses.

Tests: fast/replaced/applet-display-none.html

fast/replaced/embed-display-none.html
fast/replaced/object-display-none.html

  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::rendererIsNeeded):
  • html/HTMLElement.cpp: (WebCore::HTMLElement::rendererIsNeeded):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::rendererIsNeeded):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::rendererIsNeeded):
Location:
trunk
Files:
13 added
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r41207 r41209  
     12009-02-24  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Reviewed by Anders Carlsson
     4       
     5        https://bugs.webkit.org/show_bug.cgi?id=15081
     6       
     7        Add tests for display:none on applets, embeds and object elements.
     8
     9        * fast/replaced/applet-display-none.html: Added.
     10        * fast/replaced/embed-display-none.html: Added.
     11        * fast/replaced/object-display-none.html: Added.
     12        * fast/replaced/resources/test.swf: Copied from LayoutTests/accessibility/resources/test.swf.
     13        * platform/mac/fast/replaced/applet-display-none-expected.checksum: Added.
     14        * platform/mac/fast/replaced/applet-display-none-expected.png: Added.
     15        * platform/mac/fast/replaced/applet-display-none-expected.txt: Added.
     16        * platform/mac/fast/replaced/embed-display-none-expected.checksum: Added.
     17        * platform/mac/fast/replaced/embed-display-none-expected.png: Added.
     18        * platform/mac/fast/replaced/embed-display-none-expected.txt: Added.
     19        * platform/mac/fast/replaced/object-display-none-expected.checksum: Added.
     20        * platform/mac/fast/replaced/object-display-none-expected.png: Added.
     21        * platform/mac/fast/replaced/object-display-none-expected.txt: Added.
     22
    1232009-02-24  Sam Weinig  <sam@webkit.org>
    224

  • trunk/WebCore/ChangeLog

    r41208 r41209  
     12009-02-24  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Reviewed by Anders Carlsson
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=15081
     6       
     7        Make display:none work for applet, emebed and object elements
     8        by calling rendererIsNeeded() on superclasses.
     9
     10        Tests: fast/replaced/applet-display-none.html
     11               fast/replaced/embed-display-none.html
     12               fast/replaced/object-display-none.html
     13
     14        * html/HTMLAppletElement.cpp:
     15        (WebCore::HTMLAppletElement::rendererIsNeeded):
     16        * html/HTMLElement.cpp:
     17        (WebCore::HTMLElement::rendererIsNeeded):
     18        * html/HTMLEmbedElement.cpp:
     19        (WebCore::HTMLEmbedElement::rendererIsNeeded):
     20        * html/HTMLObjectElement.cpp:
     21        (WebCore::HTMLObjectElement::rendererIsNeeded):
     22
    1232009-02-24  Simon Fraser  <simon.fraser@apple.com>
    224

  • trunk/WebCore/html/HTMLAppletElement.cpp

    r39601 r41209  
    100100}
    101101
    102 bool HTMLAppletElement::rendererIsNeeded(RenderStyle*)
    103 {
    104     return !getAttribute(codeAttr).isNull();
     102bool HTMLAppletElement::rendererIsNeeded(RenderStyle* style)
     103{
     104    if (getAttribute(codeAttr).isNull())
     105        return false;
     106
     107    return HTMLPlugInElement::rendererIsNeeded(style);
    105108}
    106109

  • trunk/WebCore/html/HTMLElement.cpp

    r41162 r41209  
    973973            return false;
    974974    }
    975     return (document()->documentElement() == this) || (style->display() != NONE);
     975    return StyledElement::rendererIsNeeded(style);
    976976}
    977977   

  • trunk/WebCore/html/HTMLEmbedElement.cpp

    r40638 r41209  
    138138    }
    139139
    140     return true;
     140    return HTMLPlugInElement::rendererIsNeeded(style);
    141141}
    142142

  • trunk/WebCore/html/HTMLObjectElement.cpp

    r40638 r41209  
    120120bool HTMLObjectElement::rendererIsNeeded(RenderStyle* style)
    121121{
    122     if (m_useFallbackContent || isImageType())
    123         return HTMLPlugInElement::rendererIsNeeded(style);
    124 
    125122    Frame* frame = document()->frame();
    126123    if (!frame)
    127124        return false;
    128125   
    129     return true;
     126    return HTMLPlugInElement::rendererIsNeeded(style);
    130127}
    131128
Note: See TracChangeset for help on using the changeset viewer.