Changeset 41341 in webkit


Ignore:
Timestamp:
Mar 1, 2009 11:22:13 AM (15 years ago)
Author:
jmalonzo@webkit.org
Message:

2009-03-01 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] get the HTTP layout tests going
​https://bugs.webkit.org/show_bug.cgi?id=24259

Added API to get the response mime type from a frame. We need this
so we can decide if we need to dump the frame as text or its
render tree

  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp:

2009-03-01 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] get the HTTP layout tests going
​https://bugs.webkit.org/show_bug.cgi?id=24259

Determine the frame's response and decide whether to dump as text
or the render tree

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dump):

2009-02-28 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] get the HTTP layout tests going
​https://bugs.webkit.org/show_bug.cgi?id=24259

Enable http tests, excluding tests/folders that fail or untested

  • platform/gtk/Skipped:
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r41338 r41341  
     12009-02-28  Jan Michael Alonzo  <jmalonzo@webkit.org>
     2
     3        Reviewed by Holger Freyther.
     4
     5        [Gtk] get the HTTP layout tests going
     6        https://bugs.webkit.org/show_bug.cgi?id=24259
     7
     8        Enable http tests, excluding tests/folders that fail or untested
     9
     10        * platform/gtk/Skipped:
     11
    1122009-03-01  Dan Bernstein  <mitz@apple.com>
    213

  • trunk/LayoutTests/platform/gtk/Skipped

    r40301 r41341  
    21522152editing
    21532153geolocation
    2154 http
    21552154media
    21562155platform
    … …  
    22172216# Tests generating new results
    22182217transitions/transition-drt-api.html
     2218
     2219# HTTP tests
     2220# Tests in http/ directory
     2221
     2222# blacklist untested/failing folders
     2223http/tests/appcache
     2224http/tests/history
     2225http/tests/media
     2226http/tests/misc
     2227http/tests/navigation
     2228http/tests/plugins
     2229http/tests/security
     2230http/tests/ssl
     2231http/tests/webarchive
     2232http/tests/wml
     2233
     2234# tests that failed
     2235http/tests/incremental/slow-utf8-text.pl
     2236http/tests/loading/bad-scheme-subframe.html
     2237http/tests/loading/bad-server-subframe.html
     2238http/tests/loading/basic.html
     2239http/tests/loading/empty-subframe.html
     2240http/tests/loading/gmail-assert-on-load.html
     2241http/tests/loading/location-hash-reload-cycle.html
     2242http/tests/loading/onload-vs-immediate-refresh.pl
     2243http/tests/loading/slow-parsing-subframe.html
     2244http/tests/loading/text-content-type-with-binary-extension.html
     2245http/tests/xmlhttprequest/abort-should-cancel-load.html
     2246http/tests/xmlhttprequest/basic-auth.html
     2247http/tests/xmlhttprequest/close-window.html
     2248http/tests/xmlhttprequest/default-content-type-dashboard.html
     2249http/tests/xmlhttprequest/frame-load-cancelled-abort.html
     2250http/tests/xmlhttprequest/methods-async.html
     2251http/tests/xmlhttprequest/methods-lower-case.html
     2252http/tests/xmlhttprequest/methods.html
     2253http/tests/xmlhttprequest/svg-created-by-xhr-disallowed-in-dashboard.html
     2254http/tests/xmlhttprequest/upload-onload-event.html
     2255http/tests/xmlhttprequest/upload-onprogress-event.html
     2256http/tests/xmlhttprequest/upload-progress-events.html
     2257http/tests/xmlhttprequest/xhr-onunload.html
     2258
     2259# Tests that timed out
     2260http/tests/xmlhttprequest/XMLHttpRequestException.html
     2261http/tests/xmlhttprequest/connection-error-sync.html
     2262
     2263# Crashing tests
     2264http/tests/xmlhttprequest/web-apps/002.html
     2265http/tests/xmlhttprequest/zero-length-response.html
     2266
     2267# Tests that had stderr output
     2268http/tests/incremental/frame-focus-before-load.html
     2269http/tests/incremental/pause-in-script-element.pl
     2270http/tests/multipart/invalid-image-data-standalone.html
     2271http/tests/multipart/invalid-image-data.html
     2272http/tests/xmlhttprequest/abort-crash.html
     2273http/tests/xmlhttprequest/abort-should-cancel-load.html
     2274http/tests/xmlhttprequest/basic-auth.html
     2275http/tests/xmlhttprequest/close-window.html
     2276http/tests/xmlhttprequest/cookies.html
     2277http/tests/xmlhttprequest/default-content-type-dashboard.html
     2278http/tests/xmlhttprequest/web-apps/003.html
     2279http/tests/xmlhttprequest/web-apps/004.html
     2280
     2281# Tests that had no expected results (probably new):
     2282http/tests/loading/simple-subframe.html
     2283http/tests/local/file-url-sent-as-referer.html
     2284http/tests/multipart/invalid-image-data-standalone.html
     2285http/tests/multipart/invalid-image-data.html
     2286http/tests/uri/css-href.php

  • trunk/WebKit/gtk/ChangeLog

    r41339 r41341  
     12009-03-01  Jan Michael Alonzo  <jmalonzo@webkit.org>
     2
     3        Reviewed by Holger Freyther.
     4
     5         [Gtk] get the HTTP layout tests going
     6         https://bugs.webkit.org/show_bug.cgi?id=24259
     7
     8        Added API to get the response mime type from a frame. We need this
     9        so we can decide if we need to dump the frame as text or its
     10        render tree
     11
     12        * webkit/webkitprivate.h:
     13        * webkit/webkitwebframe.cpp:
     14
    1152009-03-01  Jan Michael Alonzo  <jmalonzo@webkit.org>
    216

  • trunk/WebKit/gtk/webkit/webkitprivate.h

    r41339 r41341  
    160160    webkit_web_policy_decision_cancel (WebKitWebPolicyDecision* decision);
    161161
     162    // FIXME: move this functionality into a 'WebKitWebDataSource' once implemented
     163    WEBKIT_API gchar*
     164    webkit_web_frame_get_response_mime_type(WebKitWebFrame* frame);
     165
    162166    // FIXME: Move these to webkitwebframe.h once their API has been discussed.
    163167

  • trunk/WebKit/gtk/webkit/webkitwebframe.cpp

    r41039 r41341  
    66 * Copyright (C) 2008 Collabora Ltd.
    77 * Copyright (C) 2008 Nuanti Ltd.
     8 * Copyright (C) 2009 Jan Alonzo <jmalonzo@gmail.com>
    89 *
    910 * This library is free software; you can redistribute it and/or
    … …  
    3233#include "AnimationController.h"
    3334#include "CString.h"
     35#include "DocumentLoader.h"
    3436#include "FrameLoader.h"
    3537#include "FrameLoaderClientGtk.h"
    … …  
    718720}
    719721
    720 }
     722gchar* webkit_web_frame_get_response_mime_type(WebKitWebFrame* frame)
     723{
     724    Frame* coreFrame = core(frame);
     725    DocumentLoader* docLoader = coreFrame->loader()->documentLoader();
     726    String mimeType = docLoader->responseMIMEType();
     727    return g_strdup(mimeType.utf8().data());
     728}
     729
     730}

  • trunk/WebKitTools/ChangeLog

    r41340 r41341  
     12009-03-01  Jan Michael Alonzo  <jmalonzo@webkit.org>
     2
     3        Reviewed by Holger Freyther.
     4
     5         [Gtk] get the HTTP layout tests going
     6         https://bugs.webkit.org/show_bug.cgi?id=24259
     7
     8        Determine the frame's response and decide whether to dump as text
     9        or the render tree
     10
     11        * DumpRenderTree/gtk/DumpRenderTree.cpp:
     12        (dump):
     13
    1142009-03-01  Jan Michael Alonzo  <jmalonzo@webkit.org>
    215

  • trunk/WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp

    r41340 r41341  
    5858extern gchar* webkit_web_frame_dump_render_tree(WebKitWebFrame* frame);
    5959extern void webkit_web_settings_add_extra_plugin_directory(WebKitWebView* view, const gchar* directory);
     60extern gchar* webkit_web_frame_get_response_mime_type(WebKitWebFrame* frame);
    6061}
    6162
    … …  
    223224{
    224225    invalidateAnyPreviousWaitToDumpWatchdog();
     226
     227    bool dumpAsText = gLayoutTestController->dumpAsText();
    225228    if (dumpTree) {
    226229        char* result = 0;
    227 
    228         bool dumpAsText = gLayoutTestController->dumpAsText();
    229         // FIXME: Also dump text resuls as text.
     230        gchar* responseMimeType = webkit_web_frame_get_response_mime_type(mainFrame);
     231
     232        dumpAsText = g_ascii_strcasecmp(responseMimeType, "text/plain");
     233        g_free(responseMimeType);
     234
    230235        gLayoutTestController->setDumpAsText(dumpAsText);
    231236        if (gLayoutTestController->dumpAsText())
Note: See TracChangeset for help on using the changeset viewer.