Changeset 41379 in webkit

Timestamp:

Mar 2, 2009 10:15:51 PM (15 years ago)

Author:

Simon Fraser

Message:

2009-03-02 Simon Fraser <Simon Fraser>

Reviewed by Adele Peterson

​https://bugs.webkit.org/show_bug.cgi?id=24313

If RenderTextControlSingleLine::nodeAtPoint() pokes a node into the
HitTestResult, then it had better well return |true|. And m_innerBlock
could never have been set as the hit node by the superclass, because
the superclass knows nothing about m_innerBlock.

Test: fast/forms/input-hit-test-border.html

• rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/input-hit-test-border-expected.txt (added)
• LayoutTests/fast/forms/input-hit-test-border.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderTextControlSingleLine.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-03-02  Simon Fraser  <simon.fraser@apple.com>
+
+        Reviewed by Adele Peterson
+        
+        https://bugs.webkit.org/show_bug.cgi?id=24313
+        
+        Test hit testing on the border and padding of inputs, after
+        touching code that referenced <rdar://problem/4617841>.
+
+        * fast/forms/input-hit-test-border-expected.txt: Added.
+        * fast/forms/input-hit-test-border.html: Added.
+
 2009-03-01  David Levin  <levin@chromium.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-03-02  Simon Fraser  <simon.fraser@apple.com>
+
+        Reviewed by Adele Peterson
+
+        https://bugs.webkit.org/show_bug.cgi?id=24313
+        
+        If RenderTextControlSingleLine::nodeAtPoint() pokes a node into the
+        HitTestResult, then it had better well return |true|. And m_innerBlock
+        could never have been set as the hit node by the superclass, because
+        the superclass knows nothing about m_innerBlock.
+        
+        Test: fast/forms/input-hit-test-border.html
+
+        * rendering/RenderTextControlSingleLine.cpp:
+        (WebCore::RenderTextControlSingleLine::nodeAtPoint):
+
 2009-03-02  Sam Weinig  <sam@webkit.org>
 

trunk/WebCore/rendering/RenderTextControlSingleLine.cpp

@@ -271 +271 @@
         return false;
 
-    if (result.innerNode() != node() && result.innerNode() != m_innerBlock.get())
+    if (result.innerNode() != node() && result.innerNode() != innerTextElement())
         return false;