Changeset 42221 in webkit

Timestamp:

Apr 3, 2009 5:41:04 PM (15 years ago)

Author:

timothy@apple.com

Message:

Fixes a bug where you could not type any more in the Web Inspector's
search field after the first match is selected in the Resources panel.

​https://bugs.webkit.org/show_bug.cgi?id=23982
rdar://problem/6592367

Reviewed by Darin Adler.

• inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._jumpToSearchResult): Use the window object of the frame to set the selection, not the main window.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/SourceView.js (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-04-03  Timothy Hatcher  <timothy@apple.com>
+
+        Fixes a bug where you could not type any more in the Web Inspector's
+        search field after the first match is selected in the Resources panel.
+
+        https://bugs.webkit.org/show_bug.cgi?id=23982
+        rdar://problem/6592367
+
+        Reviewed by Darin Adler.
+
+        * inspector/front-end/SourceView.js:
+        (WebInspector.SourceView.prototype._jumpToSearchResult): Use the
+        window object of the frame to set the selection, not the main window.
+
 2009-04-03  Sam Weinig  <sam@webkit.org>
 

trunk/WebCore/inspector/front-end/SourceView.js

@@ -275 +275 @@
             return;
 
-        var selection = window.getSelection();
+        var selection = this.sourceFrame.element.contentWindow.getSelection();
         selection.removeAllRanges();
         selection.addRange(foundRange);