Changeset 43342 in webkit

Timestamp:

May 7, 2009 5:36:01 AM (15 years ago)

Author:

xan@webkit.org

Message:

2009-05-07 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=25610
[GTK] text.caretOffset is reportedly always 0

Use the right function to get the caret offset in an
element. selectionStart() would only work for text
controls (there's even an ASSERT when calculating the selected
text range). Instead just get the selection and get the offset of
the start position.

• page/gtk/AccessibilityObjectWrapperAtk.cpp:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/gtk/AccessibilityObjectWrapperAtk.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-05-07  Xan Lopez  <xlopez@igalia.com>
+
+        Reviewed by Gustavo Noronha.
+
+        https://bugs.webkit.org/show_bug.cgi?id=25610
+        [GTK] text.caretOffset is reportedly always 0
+
+        Use the right function to get the caret offset in an
+        element. selectionStart() would only work for text
+        controls (there's even an ASSERT when calculating the selected
+        text range). Instead just get the selection and get the offset of
+        the start position.
+
+        * page/gtk/AccessibilityObjectWrapperAtk.cpp:
+
 2009-05-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 

trunk/WebCore/page/gtk/AccessibilityObjectWrapperAtk.cpp

@@ -488 +488 @@
 static gint webkit_accessible_text_get_caret_offset(AtkText* text)
 {
-    // TODO: Verify this, especially for RTL text.
-    return core(text)->selectionStart();
+    // TODO: Verify this for RTL text.
+    return core(text)->selection().start().offsetInContainerNode();
 }