Changeset 44438 in webkit

Timestamp:

Jun 4, 2009 4:01:51 PM (15 years ago)

Author:

eric@webkit.org

Message:

2009-06-04 Paul Godavari <​paul@chromium.org>

Reviewed by Eric Seidel.

Initialize the width of PopupMenuListBox properly for Mac Chromium.

Added a test that works only with this patch applied. The test is
a manual one, since the hit testing infrastructure in the layout
tests sends keyboard and mouse events to the main window and not
the cocoa control that implements the popup up, which means we can't
select items from the popup up.

​https://bugs.webkit.org/show_bug.cgi?id=25904

• manual-tests/select-narrow-width.html: Added.
• platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::PopupListBox): (WebCore::PopupContainer::showExternal):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• manual-tests/select-narrow-width.html (added)
• platform/chromium/PopupMenuChromium.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-06-04  Paul Godavari  <paul@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        Initialize the width of PopupMenuListBox properly for Mac Chromium.
+
+        Added a test that works only with this patch applied. The test is
+        a manual one, since the hit testing infrastructure in the layout
+        tests sends keyboard and mouse events to the main window and not
+        the cocoa control that implements the popup up, which means we can't
+        select items from the popup up.
+
+        https://bugs.webkit.org/show_bug.cgi?id=25904
+
+
+        * manual-tests/select-narrow-width.html: Added.
+        * platform/chromium/PopupMenuChromium.cpp:
+        (WebCore::PopupListBox::PopupListBox):
+        (WebCore::PopupContainer::showExternal):
+
 2009-06-04  Brent Fulgham  <bfulgham@webkit.org>
 

trunk/WebCore/platform/chromium/PopupMenuChromium.cpp

@@ -156 +156 @@
         , m_willAcceptOnAbandon(false)
         , m_visibleRows(0)
+        , m_baseWidth(0)
         , m_popupClient(client)
         , m_repeatingChar(0)
@@ -351 +352 @@
         return;
 
+    listBox()->setBaseWidth(rect.width());
     listBox()->updateFromElement();