Changeset 44632 in webkit

Timestamp:

Jun 12, 2009 3:24:28 PM (15 years ago)

Author:

kov@webkit.org

Message:

2009-06-12 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=25599
[GTK] Enable more tests

Implement dumping of status callback.

• DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewStatusBarTextChanged): (main):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/Skipped (modified) (1 diff)
• WebKitTools/ChangeLog (modified) (1 diff)
• WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-06-12  Gustavo Noronha Silva  <gns@gnome.org>
+
+        Reviewed by Jan Alonzo.
+
+        Enable test that uses the now implemented dumpStatusCallbacks()
+        call.
+
+        * platform/gtk/Skipped:
+
 2009-06-11  Ryosuke Niwa  <rniwa@google.com>
 

trunk/LayoutTests/platform/gtk/Skipped

@@ -1595 +1595 @@
 fast/css/getComputedStyle/computed-style-without-renderer.html
 fast/css/getComputedStyle/computed-style.html
-fast/dom/assign-to-window-status.html
 fast/dom/client-width-height-quirks.html
 fast/dom/client-width-height.html

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-06-12  Gustavo Noronha Silva  <gns@gnome.org>
+
+        Reviewed by Jan Alonzo.
+
+        https://bugs.webkit.org/show_bug.cgi?id=25599
+        [GTK] Enable more tests
+
+        Implement dumping of status callback.
+
+        * DumpRenderTree/gtk/DumpRenderTree.cpp:
+        (webViewStatusBarTextChanged):
+        (main):
+
 2009-06-11  John Abd-El-Malek  <jam@chromium.org>
 

trunk/WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp

@@ -519 +519 @@
 }
 
+static void webViewStatusBarTextChanged(WebKitWebView* view, const gchar* message, gpointer data)
+{
+    // Are we doing anything wrong? One test that does not call
+    // dumpStatusCallbacks gets true here
+    if (gLayoutTestController->dumpStatusCallbacks()) {
+        if (message && strcmp(message, ""))
+            printf("UI DELEGATE STATUS CALLBACK: setStatusText:%s\n", message);
+    }
+}
+
 int main(int argc, char* argv[])
 {
@@ -561 +571 @@
     g_signal_connect(G_OBJECT(webView), "title-changed", G_CALLBACK(webViewTitleChanged), 0);
     g_signal_connect(G_OBJECT(webView), "navigation-policy-decision-requested", G_CALLBACK(webViewNavigationPolicyDecisionRequested), 0);
+    g_signal_connect(G_OBJECT(webView), "status-bar-text-changed", G_CALLBACK(webViewStatusBarTextChanged), 0);
 
     setDefaultsToConsistentStateValuesForTesting();