Changeset 44841 in webkit

Timestamp:

Jun 18, 2009 10:06:20 PM (15 years ago)

Author:

krit@webkit.org

Message:

2009-06-18 Dirk Schulze <​krit@webkit.org>

Reviewed by Oliver Hunt.

feOffset and objectBoundingBox
​https://bugs.webkit.org/show_bug.cgi?id=26441

If we use objectBoundingBox for primitiveUnits, the fractions given
to dx or dy of feOffset must be multiplied with the referenced objects
objectBoundingBox size.

Test: svg/filters/feOffset.svg

• svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):

Test for feOffset with the primitiveUnits objectBoundingBox
and userSpaceOnUse.

• platform/mac/svg/filters/feOffset-expected.checksum: Added.
• platform/mac/svg/filters/feOffset-expected.png: Added.
• platform/mac/svg/filters/feOffset-expected.txt: Added.
• svg/filters/feOffset.svg: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/svg/filters/feOffset-expected.checksum (added)
• LayoutTests/platform/mac/svg/filters/feOffset-expected.png (added)
• LayoutTests/platform/mac/svg/filters/feOffset-expected.txt (added)
• LayoutTests/svg/filters/feOffset.svg (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/svg/graphics/filters/SVGFEOffset.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-06-18  Dirk Schulze  <krit@webkit.org>
+
+        Reviewed by Oliver Hunt.
+
+        Test for feOffset with the primitiveUnits objectBoundingBox
+        and userSpaceOnUse.
+
+        * platform/mac/svg/filters/feOffset-expected.checksum: Added.
+        * platform/mac/svg/filters/feOffset-expected.png: Added.
+        * platform/mac/svg/filters/feOffset-expected.txt: Added.
+        * svg/filters/feOffset.svg: Added.
+
 2009-06-18  Dirk Schulze  <krit@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-06-18  Dirk Schulze  <krit@webkit.org>
+
+        Reviewed by Oliver Hunt.
+
+        feOffset and objectBoundingBox
+        [https://bugs.webkit.org/show_bug.cgi?id=26441]
+
+        If we use objectBoundingBox for primitiveUnits, the fractions given
+        to dx or dy of feOffset must be multiplied with the referenced objects
+        objectBoundingBox size.
+
+        Test: svg/filters/feOffset.svg
+
+        * svg/graphics/filters/SVGFEOffset.cpp:
+        (WebCore::FEOffset::apply):
+
 2009-06-18  Dirk Schulze  <krit@webkit.org>
 

trunk/WebCore/svg/graphics/filters/SVGFEOffset.cpp

@@ -75 +75 @@
         return;
 
+    if (filter->effectBoundingBoxMode()) {
+        setDx(dx() * filter->sourceImageRect().width());
+        setDy(dy() * filter->sourceImageRect().height());
+    }
+
     FloatRect dstRect = FloatRect(dx() + m_in->subRegion().x() - subRegion().x(),
                                   dy() + m_in->subRegion().y() - subRegion().y(),