Changeset 45062 in webkit


Ignore:
Timestamp:
Jun 23, 2009 11:26:04 PM (15 years ago)
Author:
eric@webkit.org
Message:

2009-06-23 Eric Seidel <eric@webkit.org>

Reviewed by Dave Levin.

Fix missing comment message during land-patches and SVN.commit_with_message respecting --dry-run
https://bugs.webkit.org/show_bug.cgi?id=26669

  • Scripts/bugzilla-tool:
  • Scripts/modules/scm.py:
Location:
trunk/WebKitTools
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKitTools/ChangeLog

    r45032 r45062  
     12009-06-23  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Dave Levin.
     4
     5        Fix missing comment message during land-patches and SVN.commit_with_message respecting --dry-run
     6        https://bugs.webkit.org/show_bug.cgi?id=26669
     7
     8        * Scripts/bugzilla-tool:
     9        * Scripts/modules/scm.py:
     10
    1112009-06-23  Takeshi Yoshino  <tyoshino@google.com>
    212
  • trunk/WebKitTools/Scripts/bugzilla-tool

    r45026 r45062  
    231231        try:
    232232            patches = tool.bugs.fetch_reviewed_patches_from_bug(bug_id)
    233             commit_text = ""
     233            comment_text = ""
    234234
    235235            os.chdir(tool.scm().checkout_root)
     
    254254
    255255            if len(patches) > 1:
    256                 commit_text = "All reviewed patches landed, closing."
    257 
    258             tool.bugs.close_bug_as_fixed(bug_id, commit_text)
     256                comment_text = "All reviewed patches landed, closing."
     257
     258            tool.bugs.close_bug_as_fixed(bug_id, comment_text)
    259259        except ScriptError, error:
    260260            log(error)
  • trunk/WebKitTools/Scripts/modules/scm.py

    r45026 r45062  
    7676            error("Working directory has modifications, pass --force-clean or --no-clean to continue.")
    7777       
    78         log("Cleaning the working directory")
     78        log("Cleaning working directory")
    7979        self.clean_working_directory()
    8080   
     
    205205
    206206    def commit_with_message(self, message):
     207        if self.dryrun:
     208            return "Dry run, no remote commit."
    207209        return self.run_command('svn commit -F -', input=message)
    208210
Note: See TracChangeset for help on using the changeset viewer.