Changeset 45152 in webkit
- Timestamp:
- Jun 25, 2009 12:42:33 AM (15 years ago)
- Location:
- trunk/WebKitTools
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebKitTools/ChangeLog
r45147 r45152 1 2009-06-25 Eric Seidel <eric@webkit.org> 2 3 Reviewed by Tor Arne Vestbø. 4 5 Remove use of os.system to fix reviewers with unicode chars in their names 6 https://bugs.webkit.org/show_bug.cgi?id=26713 7 8 Also change to latin1 encoding of ø to make python happy. 9 10 * Scripts/modules/bugzilla.py: 11 * Scripts/modules/scm.py: 12 1 13 2009-06-25 Eric Seidel <eric@webkit.org> 2 14 -
trunk/WebKitTools/Scripts/modules/bugzilla.py
r45147 r45152 103 103 "timothy" : "Timothy Hatcher", 104 104 "treat" : "Adam Treat", 105 "vestbo" : u'Tor Arne Vestb\x c3',105 "vestbo" : u'Tor Arne Vestb\xf8', 106 106 "xan.lopez" : "Xan Lopez", 107 107 "zecke" : "Holger Freyther", -
trunk/WebKitTools/Scripts/modules/scm.py
r45062 r45152 92 92 # It's possible that the patch was not made from the root directory. 93 93 # We should detect and handle that case. 94 return_code = os.system('curl %s | svn-apply --reviewer "%s"' % (patch['url'], patch['reviewer'])) 94 curl_process = subprocess.Popen(['curl', patch['url']], stdout=subprocess.PIPE) 95 patch_apply_process = subprocess.Popen(['svn-apply', '--reviewer', patch['reviewer']], stdin=curl_process.stdout) 96 97 return_code = patch_apply_process.wait() 95 98 if return_code: 96 99 raise ScriptError("Patch " + patch['url'] + " failed to download and apply.")
Note: See TracChangeset
for help on using the changeset viewer.