Changeset 45252 in webkit


Ignore:
Timestamp:
Jun 26, 2009 2:12:44 AM (15 years ago)
Author:
xan@webkit.org
Message:

2009-06-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25529
[Gtk] Expected states not exposed to assistive technologies

Add support for VISIBLE, EDITABLE and SENSITIVE states.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (setAtkStateSetFromCoreObject):
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r45251 r45252  
     12009-06-26  Xan Lopez  <xlopez@igalia.com>
     2
     3        Reviewed by Jan Alonzo.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=25529
     6        [Gtk] Expected states not exposed to assistive technologies
     7
     8        Add support for VISIBLE, EDITABLE and SENSITIVE states.
     9
     10        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
     11        (setAtkStateSetFromCoreObject):
     12
    1132009-06-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
    214
  • trunk/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp

    r44722 r45252  
    294294        atk_state_set_add_state(stateSet, ATK_STATE_CHECKED);
    295295
    296     if (!coreObject->isReadOnly())
     296    // FIXME: isReadOnly does not seem to do the right thing for
     297    // controls, so check explicitly for them
     298    if (!coreObject->isReadOnly() ||
     299        (coreObject->isControl() && coreObject->canSetValueAttribute()))
    297300        atk_state_set_add_state(stateSet, ATK_STATE_EDITABLE);
    298301
    299     if (coreObject->isEnabled())
     302    // FIXME: Put both ENABLED and SENSITIVE together here for now
     303    if (coreObject->isEnabled()) {
    300304        atk_state_set_add_state(stateSet, ATK_STATE_ENABLED);
     305        atk_state_set_add_state(stateSet, ATK_STATE_SENSITIVE);
     306    }
    301307
    302308    if (coreObject->canSetFocusAttribute())
     
    321327    // TODO: ATK_STATE_SELECTABLE_TEXT
    322328
    323     // TODO: ATK_STATE_SENSITIVE
    324 
    325329    if (coreObject->isSelected())
    326330        atk_state_set_add_state(stateSet, ATK_STATE_SELECTED);
    327331
    328     if (!coreObject->isOffScreen())
     332    // FIXME: Group both SHOWING and VISIBLE here for now
     333    // Not sure how to handle this in WebKit, see bug
     334    // http://bugzilla.gnome.org/show_bug.cgi?id=509650 for other
     335    // issues with SHOWING vs VISIBLE within GTK+
     336    if (!coreObject->isOffScreen()) {
    329337        atk_state_set_add_state(stateSet, ATK_STATE_SHOWING);
     338        atk_state_set_add_state(stateSet, ATK_STATE_VISIBLE);
     339    }
    330340
    331341    // Mutually exclusive, so we group these two
Note: See TracChangeset for help on using the changeset viewer.