Changeset 45464 in webkit

Timestamp:

Jul 1, 2009 10:13:41 PM (15 years ago)

Author:

eric@webkit.org

Message:

2009-07-01 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej Stachowiak.

prepare-ChangeLog should have a --bug= argument and use it for url autofill
​https://bugs.webkit.org/show_bug.cgi?id=26383

prepare-ChangeLog now knows how to grab the bug title from bugs.webkit.org
I also added a bit more template text in an effort to get better ChangeLogs
from casual contributers.

• Scripts/prepare-ChangeLog:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/prepare-ChangeLog (modified) (4 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-07-01  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Maciej Stachowiak.
+
+        prepare-ChangeLog should have a --bug= argument and use it for url autofill
+        https://bugs.webkit.org/show_bug.cgi?id=26383
+
+        prepare-ChangeLog now knows how to grab the bug title from bugs.webkit.org
+        I also added a bit more template text in an effort to get better ChangeLogs
+        from casual contributers.
+
+        * Scripts/prepare-ChangeLog:
+
 2009-07-01  Eric Seidel  <eric@webkit.org>
 

trunk/WebKitTools/Scripts/prepare-ChangeLog

@@ -97 +97 @@
 my $changeLogTimeZone = "PST8PDT";
 
+my $bugNumber;
 my $name;
 my $emailAddress;
@@ -108 +109 @@
 my $parseOptionsResult =
     GetOptions("diff|d!" => \$spewDiff,
+               "bug:i" => \$bugNumber,
                "name:s" => \$name,
                "email:s" => \$emailAddress,
@@ -245 +247 @@
 print STDERR "  Change author: $name <$emailAddress>.\n";
 
+my $bugDescription;
+my $bugURL;
+if ($bugNumber) {
+    $bugURL = "https://bugs.webkit.org/show_bug.cgi?id=$bugNumber";
+    my $bugXMLURL = "$bugURL&ctype=xml";
+    # Perl has no built in XML processing, so we'll fetch and parse with curl and grep
+    my $descriptionLine = `curl --silent "$bugXMLURL" | grep short_desc`;
+    $descriptionLine =~ /<short_desc>(.*)<\/short_desc>/;
+    $bugDescription = $1;
+    print STDERR "  Description from bug $bugNumber:\n    \"$bugDescription\".\n";
+}
+
 # Remove trailing parenthesized notes from user name (bit of hack).
 $name =~ s/\(.*?\)\s*$//g;
@@ -321 +335 @@
     print CHANGE_LOG normalizeLineEndings($description . "\n", $endl) if $description;
 
+    $bugDescription = "SHORT DESCRIPTION/BUG TITLE GOES HERE (OOPS!)" unless $bugDescription;
+    print CHANGE_LOG normalizeLineEndings("        $bugDescription\n", $endl);
+
+    $bugURL = "BUG URL GOES HERE (pass --bug= to autofill)" unless $bugURL;
+    print CHANGE_LOG normalizeLineEndings("        $bugURL\n\n", $endl);
+
+    # We could pre-populate this with the git commit log or with the bug description.
+    print CHANGE_LOG normalizeLineEndings("        DETAILED DESCRIPTION OF THE CHANGES GOES HERE. (OOPS!) SEE:\n", $endl);
+    print CHANGE_LOG normalizeLineEndings("        http://webkit.org/coding/contributing.html FOR MORE INFORMATION\n\n", $endl);
+
     if ($prefix =~ m/WebCore/ || `pwd` =~ m/WebCore/) {
         if ($didChangeRegressionTests) {
             print CHANGE_LOG normalizeLineEndings(testListForChangeLog(sort @addedRegressionTests), $endl);
         } else {
-            print CHANGE_LOG normalizeLineEndings("        WARNING: NO TEST CASES ADDED OR CHANGED\n\n", $endl);
+            print CHANGE_LOG normalizeLineEndings("        LIST OF TESTS, OR EXPLANATION WHY TESTING IS IMPOSSIBLE GOES HERE (OOPS!)\n\n", $endl);
         }
     }