Changeset 45468 in webkit


Ignore:
Timestamp:
Jul 1, 2009 11:30:05 PM (15 years ago)
Author:
Simon Fraser
Message:

2009-07-01 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

<video> fails to show on ​http://camendesign.com/code/video_for_everybody
<rdar://problem/7026010>
​https://bugs.webkit.org/show_bug.cgi?id=26919

Fix an issue introduced in r44961. In that revision we changed to only update
compositing layer geometry when all siblings had been laid out (i.e. we pushed
the updates one level down). However, that left out the root layer, so this
fix ensures that the root layer geometry gets updated at the end.

Test: compositing/geometry/root-layer-update.html

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterLayout):
Location:
trunk
Files:
4 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r45466 r45468  
    55
    66        * platform/gtk/Skipped:
     7
     82009-07-01  Simon Fraser  <simon.fraser@apple.com>
     9
     10        Reviewed by Dan Bernstein.
     11
     12        <video> fails to show on http://camendesign.com/code/video_for_everybody
     13        <rdar://problem/7026010>
     14        https://bugs.webkit.org/show_bug.cgi?id=26919
     15       
     16        Testcase for changing the root layer size, and ensuring that all
     17        the compositing layers are correctly repositioned.
     18
     19        * compositing/geometry/root-layer-update.html: Added.
     20        * platform/mac/compositing/geometry/root-layer-update-expected.checksum: Added.
     21        * platform/mac/compositing/geometry/root-layer-update-expected.png: Added.
     22        * platform/mac/compositing/geometry/root-layer-update-expected.txt: Added.
    723
    8242009-07-01  Simon Fraser  <simon.fraser@apple.com>

  • trunk/WebCore/ChangeLog

    r45467 r45468  
    1717        (WebCore::MessagePortChannel::MessagePortChannel):
    1818        (WebCore::MessagePortChannel::~MessagePortChannel):
     19
     202009-07-01  Simon Fraser  <simon.fraser@apple.com>
     21
     22        Reviewed by Dan Bernstein.
     23
     24        <video> fails to show on http://camendesign.com/code/video_for_everybody
     25        <rdar://problem/7026010>
     26        https://bugs.webkit.org/show_bug.cgi?id=26919
     27
     28        Fix an issue introduced in r44961. In that revision we changed to only update
     29        compositing layer geometry when all siblings had been laid out (i.e. we pushed
     30        the updates one level down). However, that left out the root layer, so this
     31        fix ensures that the root layer geometry gets updated at the end.
     32
     33        Test: compositing/geometry/root-layer-update.html
     34
     35        * rendering/RenderLayerBacking.cpp:
     36        (WebCore::RenderLayerBacking::updateAfterLayout):
    1937
    20382009-07-01  Simon Fraser  <simon.fraser@apple.com>

  • trunk/WebCore/rendering/RenderLayerBacking.cpp

    r45387 r45468  
    141141        layerCompositor->updateCompositingDescendantGeometry(m_owningLayer, m_owningLayer, updateDepth);
    142142       
    143         if (!m_owningLayer->parent())
     143        if (!m_owningLayer->parent()) {
     144            updateGraphicsLayerGeometry();
    144145            layerCompositor->updateRootLayerPosition();
     146        }
    145147    }
    146148}
Note: See TracChangeset for help on using the changeset viewer.