Changeset 45564 in webkit

Timestamp:

Jul 6, 2009 1:55:28 PM (15 years ago)

Author:

Nate Chapin

Message:

2009-07-06 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Fix a bunch of layout test crahses in Chromium caused by a bad usage of DEFINE_STATIC_LOCAL.

​https://bugs.webkit.org/show_bug.cgi?id=26997

• bindings/v8/V8Binding.cpp: (WebCore::v8ValueToWebCoreString): Use a regular static declaration instead of DEFINE_STATIC_LOCAL.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/V8Binding.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-07-06  Nate Chapin  <japhet@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        Fix a bunch of layout test crahses in Chromium caused by a bad usage of DEFINE_STATIC_LOCAL.
+
+        https://bugs.webkit.org/show_bug.cgi?id=26997
+
+        * bindings/v8/V8Binding.cpp:
+        (WebCore::v8ValueToWebCoreString): Use a regular static declaration instead of DEFINE_STATIC_LOCAL.
+
 2009-07-06  Pavel Feldman  <pfeldman@chromium.org>
 

trunk/WebCore/bindings/v8/V8Binding.cpp

@@ -39 +39 @@
 
 #include <v8.h>
-#include <wtf/StdLibExtras.h>
 
 namespace WebCore {
@@ -103 +102 @@
         // Most numbers used are <= 100. Even if they aren't used there's very little in using the space.
         const int kLowNumbers = 100;
-        DEFINE_STATIC_LOCAL(AtomicString*, lowNumbers, [kLowNumbers + 1]);
+        static AtomicString lowNumbers[kLowNumbers + 1];
         String webCoreString;
         if (0 <= value && value <= kLowNumbers) {