Changeset 45580 in webkit

Timestamp:

Jul 6, 2009 7:18:41 PM (15 years ago)

Author:

eric@webkit.org

Message:

2009-07-06 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej Stachowiak.

bugzilla-tool fails to close bugs with bugzilla 3.0
​https://bugs.webkit.org/show_bug.cgi?id=27008

Update bugzilla.py to match changes in the bug page "changeform"
Update scm.py to add bug_ids to attachments to make error reporting nicer.

• Scripts/modules/bugzilla.py:
• Scripts/modules/scm.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/modules/bugzilla.py (modified) (2 diffs)
• Scripts/modules/scm.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-07-06  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Maciej Stachowiak.
+
+        bugzilla-tool fails to close bugs with bugzilla 3.0
+        https://bugs.webkit.org/show_bug.cgi?id=27008
+
+        Update bugzilla.py to match changes in the bug page "changeform"
+        Update scm.py to add bug_ids to attachments to make error reporting nicer.
+
+        * Scripts/modules/bugzilla.py:
+        * Scripts/modules/scm.py:
+
 2009-07-03  Maciej Stachowiak  <mjs@apple.com>
 

trunk/WebKitTools/Scripts/modules/bugzilla.py

@@ -144 +144 @@
         for element in soup.findAll('attachment'):
             attachment = {}
+            attachment['bug_id'] = bug_id
             attachment['is_obsolete'] = (element.has_key('isobsolete') and element['isobsolete'] == "1")
             attachment['is_patch'] = (element.has_key('ispatch') and element['ispatch'] == "1")
@@ -294 +295 @@
             log(comment_text)
             self.browser['comment'] = comment_text
-        self.browser['knob'] = ['resolve']
+        self.browser['bug_status'] = ['RESOLVED']
         self.browser['resolution'] = ['FIXED']
         self.browser.submit()

trunk/WebKitTools/Scripts/modules/scm.py

@@ -100 +100 @@
         return_code = patch_apply_process.wait()
         if return_code:
-            raise ScriptError("Patch " + patch['url'] + " failed to download and apply.")
+            raise ScriptError("Patch %s from bug %s failed to download and apply." % (patch['url'], patch['bug_id']))
 
     def run_status_and_extract_filenames(self, status_command, status_regexp):