Changeset 45999 in webkit

Timestamp:

Jul 16, 2009 5:16:21 PM (15 years ago)

Author:

abarth@webkit.org

Message:

WebCore:

2009-07-16 Adam Barth <​abarth@webkit.org>

Unreviewed.

Revert 45987. Tests did not pass on Windows.

• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::appendFormData):

LayoutTests:

2009-07-16 Adam Barth <​abarth@webkit.org>

Unreviewed.

Revert 45987. Tests did not pass on Windows.

• fast/forms/get-file-upload-expected.txt: Removed.
• fast/forms/get-file-upload.html: Removed.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/get-file-upload-expected.txt (deleted)
• LayoutTests/fast/forms/get-file-upload.html (deleted)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLInputElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-07-16  Adam Barth  <abarth@webkit.org>
+
+        Unreviewed.
+
+        Revert 45987.  Tests did not pass on Windows.
+
+        * fast/forms/get-file-upload-expected.txt: Removed.
+        * fast/forms/get-file-upload.html: Removed.
+
 2009-07-16  Shinichiro Hamaji  <hamaji@chromium.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-07-16  Adam Barth  <abarth@webkit.org>
+
+        Unreviewed.
+
+        Revert 45987.  Tests did not pass on Windows.
+
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::appendFormData):
+
 2009-07-16  Drew Wilson  <atwilson@google.com>
 

trunk/WebCore/html/HTMLInputElement.cpp

@@ -839 +839 @@
 
         case FILE: {
-            unsigned numFiles = m_fileList->length();
-            if (!multipart) {
-                // Send only the basenames.
-                // 4.10.16.4 and 4.10.16.6 sections in HTML5.
-
-                // Unlike the multipart case, we have no special
-                // handling for the empty fileList because Netscape
-                // doesn't support for non-multipart submission of
-                // file inputs, and Firefox doesn't add "name=" query
-                // parameter.
-
-                for (unsigned i = 0; i < numFiles; ++i) {
-                    encoding.appendData(name(), m_fileList->item(i)->fileName());
-                }
-                return true;
-            }
+            // Can't submit file on GET.
+            if (!multipart)
+                return false;
 
             // If no filename at all is entered, return successful but empty.
             // Null would be more logical, but Netscape posts an empty file. Argh.
+            unsigned numFiles = m_fileList->length();
             if (!numFiles) {
                 encoding.appendFile(name(), File::create(""));