Changeset 46006 in webkit

Timestamp:

Jul 16, 2009 9:36:24 PM (15 years ago)

Author:

abarth@webkit.org

Message:

2009-07-16 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel and Adam Barth.

A test for for non-multipart file upload form submission.
This test is disabled for non-Mac platforms because of beginDragWithFiles().
<​https://bugs.webkit.org/show_bug.cgi?id=26505>

• fast/forms/get-file-upload-expected.txt: Added.
• fast/forms/get-file-upload.html: Added.
• platform/gtk/Skipped:
• platform/qt/Skipped:
• platform/win/Skipped:

2009-07-16 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel.

Sends the basename of a selected file for non-multipart form submission.
<​https://bugs.webkit.org/show_bug.cgi?id=26505>

Test: fast/forms/get-file-upload.html

• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::appendFormData):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/get-file-upload-expected.txt (added)
• LayoutTests/fast/forms/get-file-upload.html (added)
• LayoutTests/platform/gtk/Skipped (modified) (1 diff)
• LayoutTests/platform/qt/Skipped (modified) (1 diff)
• LayoutTests/platform/win/Skipped (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLInputElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-07-16  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Eric Seidel and Adam Barth.
+
+        A test for for non-multipart file upload form submission.
+        This test is disabled for non-Mac platforms because of beginDragWithFiles().
+        <https://bugs.webkit.org/show_bug.cgi?id=26505>
+
+        * fast/forms/get-file-upload-expected.txt: Added.
+        * fast/forms/get-file-upload.html: Added.
+        * platform/gtk/Skipped:
+        * platform/qt/Skipped:
+        * platform/win/Skipped:
+
 2009-07-16  Dan Bernstein  <mitz@apple.com>
 

trunk/LayoutTests/platform/gtk/Skipped

@@ -1739 +1739 @@
 fast/forms/focus-selection-textarea.html
 fast/forms/form-and-frame-interaction-retains-values.html
+fast/forms/get-file-upload.html
 fast/forms/input-radio-checked-tab.html
 fast/forms/input-select-on-click.html

trunk/LayoutTests/platform/qt/Skipped

@@ -19 +19 @@
 fast/events/drag-to-navigate.html
 fast/events/prevent-drag-to-navigate.html
+fast/forms/get-file-upload.html
 http/tests/security/clipboard/clipboard-file-access.html
 

trunk/LayoutTests/platform/win/Skipped

@@ -186 +186 @@
 fast/events/drag-to-navigate.html
 fast/events/prevent-drag-to-navigate.html
+fast/forms/get-file-upload.html
 http/tests/security/clipboard/clipboard-file-access.html
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-07-16  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        Sends the basename of a selected file for non-multipart form submission.
+        <https://bugs.webkit.org/show_bug.cgi?id=26505>
+
+        Test: fast/forms/get-file-upload.html
+
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::appendFormData):
+
 2009-07-16  Adam Barth  <abarth@webkit.org>
 

trunk/WebCore/html/HTMLInputElement.cpp

@@ -839 +839 @@
 
         case FILE: {
-            // Can't submit file on GET.
-            if (!multipart)
-                return false;
+            unsigned numFiles = m_fileList->length();
+            if (!multipart) {
+                // Send only the basenames.
+                // 4.10.16.4 and 4.10.16.6 sections in HTML5.
+
+                // Unlike the multipart case, we have no special
+                // handling for the empty fileList because Netscape
+                // doesn't support for non-multipart submission of
+                // file inputs, and Firefox doesn't add "name=" query
+                // parameter.
+
+                for (unsigned i = 0; i < numFiles; ++i) {
+                    encoding.appendData(name(), m_fileList->item(i)->fileName());
+                }
+                return true;
+            }
 
             // If no filename at all is entered, return successful but empty.
             // Null would be more logical, but Netscape posts an empty file. Argh.
-            unsigned numFiles = m_fileList->length();
             if (!numFiles) {
                 encoding.appendFile(name(), File::create(""));