Changeset 46235 in webkit

Timestamp:

Jul 22, 2009 1:18:50 PM (15 years ago)

Author:

treat@webkit.org

Message:

Revert bugfix for 27557 as this is invalid according to Darin Adler
who states that include order sorting should be case-sensitive.

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/modules/cpplint.py (modified) (1 diff)
• Scripts/modules/cpplint_unittest.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ -1 @@
-2009-07-22  Jakob Petsovits  <jakob.petsovits@torchmobile.com>
-
-        Reviewed by Adam Treat.
-
-        Case-insensitive comparison of include file order for cpplint.
-        https://bugs.webkit.org/show_bug.cgi?id=27557
-
-        * Scripts/modules/cpplint.py:
-        * Scripts/modules/cpplint_unittest.py:
-
 2009-07-22  Jakob Petsovits  <jakob.petsovits@torchmobile.com>
 

trunk/WebKitTools/Scripts/modules/cpplint.py

@@ -2227 +2227 @@
                  if previous_match:
                     previous_header_type = include_state.header_types[previous_line_number]
-                    if previous_header_type == _OTHER_HEADER and previous_line.strip().lower() > line.strip().lower():
+                    if previous_header_type == _OTHER_HEADER and previous_line.strip() > line.strip():
                         error(filename, line_number, 'build/include_order', 4,
                               'Alphabetical sorting problem.')

trunk/WebKitTools/Scripts/modules/cpplint_unittest.py

@@ -2095 +2095 @@
 
         self.assert_language_rules_check('foo.h',
-                                         '#include "a.h"\n'
-                                         '#include "B.h"\n'
-                                         '#include "c.h"\n',
-                                         '')
-
-        self.assert_language_rules_check('foo.h',
                                          '#include <assert.h>\n'
                                          '#include "bar.h"\n',