Changeset 46498 in webkit


Ignore:
Timestamp:
Jul 28, 2009 1:28:40 PM (15 years ago)
Author:
jorlow@chromium.org
Message:

2009-07-28 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Adam Barth.

Add some checks to existing DOM Storage LayoutTests.
​https://bugs.webkit.org/show_bug.cgi?id=27695

This is really a mixed bag of tweaks to existing tests.

  • storage/domstorage/localstorage/delete-removal-expected.txt:
  • storage/domstorage/localstorage/delete-removal.html:

Made output more readable, added redundant deletes, added deletes to
keys with the same name in different case.

  • storage/domstorage/localstorage/enumerate-storage.html:

Removed dead code.

  • storage/domstorage/localstorage/enumerate-with-length-and-key-expected.txt: Added.
  • storage/domstorage/localstorage/enumerate-with-length-and-key.html: Copied from LayoutTests/storage/domstorage/localstorage/enumerate-storage.html.

Test enumerating by hand (with length+key).

  • storage/domstorage/localstorage/iframe-events-expected.txt:
  • storage/domstorage/localstorage/iframe-events.html:

Test removeItem and clear in addition to setItem.

  • storage/domstorage/localstorage/onstorage-attribute-setwindow-expected.txt: Copied from LayoutTests/storage/domstorage/localstorage/onstorage-attribute-setattribute-expected.txt.
  • storage/domstorage/localstorage/onstorage-attribute-setwindow.html: Copied from LayoutTests/storage/domstorage/localstorage/onstorage-attribute-setattribute.html.

Test using window.onstorage.

  • storage/domstorage/window-attributes-exist-expected.txt:
  • storage/domstorage/window-attributes-exist.html:

Verify that two consecutive calls to window.Storage will equal each other.

Location:
trunk/LayoutTests
Files:
1 added
8 edited
3 copied

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r46487 r46498  
     12009-07-28  Jeremy Orlow  <jorlow@chromium.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        Add some checks to existing DOM Storage LayoutTests.
     6        https://bugs.webkit.org/show_bug.cgi?id=27695
     7
     8        This is really a mixed bag of tweaks to existing tests.
     9
     10        * storage/domstorage/localstorage/delete-removal-expected.txt:
     11        * storage/domstorage/localstorage/delete-removal.html:
     12              Made output more readable, added redundant deletes, added deletes to
     13              keys with the same name in different case.
     14        * storage/domstorage/localstorage/enumerate-storage.html:
     15              Removed dead code.
     16        * storage/domstorage/localstorage/enumerate-with-length-and-key-expected.txt: Added.
     17        * storage/domstorage/localstorage/enumerate-with-length-and-key.html: Copied from LayoutTests/storage/domstorage/localstorage/enumerate-storage.html.
     18              Test enumerating by hand (with length+key).
     19        * storage/domstorage/localstorage/iframe-events-expected.txt:
     20        * storage/domstorage/localstorage/iframe-events.html:
     21              Test removeItem and clear in addition to setItem.
     22        * storage/domstorage/localstorage/onstorage-attribute-setwindow-expected.txt: Copied from LayoutTests/storage/domstorage/localstorage/onstorage-attribute-setattribute-expected.txt.
     23        * storage/domstorage/localstorage/onstorage-attribute-setwindow.html: Copied from LayoutTests/storage/domstorage/localstorage/onstorage-attribute-setattribute.html.
     24              Test using window.onstorage.
     25        * storage/domstorage/window-attributes-exist-expected.txt:
     26        * storage/domstorage/window-attributes-exist.html:
     27              Verify that two consecutive calls to window.____Storage will equal each other.
     28
    1292009-07-28  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
    230

  • trunk/LayoutTests/storage/domstorage/localstorage/delete-removal-expected.txt

    r33565 r46498  
    11This test makes sure that using the syntax `delete localStorage.keyName` works as an alias to `localStorage.removeItem(keyName).`
    2 foo is: undefined
    3 foo is: bar
    4 foo is: undefined
    5 foo is: bar
    6 foo is: undefined
    7 foo is: bar
    8 foo is: undefined
     2foo (before anything) is: undefined
     3foo (after a named property settter set) is: bar
     4foo (after a delete) is: undefined
     5foo (after an indexed setter set) is: bar
     6foo (after deleting FOO (not foo)) is: bar
     7foo (after a delete) is: undefined
     8foo (after calling setItem) is: bar
     9foo (after a delete) is: undefined
     10foo (after a redundant delete) is: undefined
     11foo (after an implicit settter set) is: bar
     12foo (after an indexed delete) is: undefined
    913

  • trunk/LayoutTests/storage/domstorage/localstorage/delete-removal.html

    r46314 r46498  
    2020    }
    2121   
    22     log("foo is: " + localStorage.foo);
     22    log("foo (before anything) is: " + localStorage.foo);
    2323    localStorage.foo = "bar";
    24     log("foo is: " + localStorage.foo);
     24    log("foo (after a named property settter set) is: " + localStorage.foo);
    2525    delete localStorage.foo;
    26     log("foo is: " + localStorage.foo);
     26    log("foo (after a delete) is: " + localStorage.foo);
    2727    localStorage["foo"] = "bar";
    28     log("foo is: " + localStorage.foo);
     28    log("foo (after an indexed setter set) is: " + localStorage.foo);
     29    delete localStorage.FOO;
     30    log("foo (after deleting FOO (not foo)) is: " + localStorage.foo);
    2931    delete localStorage.foo;
    30     log("foo is: " + localStorage.foo);
     32    log("foo (after a delete) is: " + localStorage.foo);
    3133    localStorage.setItem("foo", "bar");
    32     log("foo is: " + localStorage.foo);
     34    log("foo (after calling setItem) is: " + localStorage.foo);
    3335    delete localStorage.foo;
    34     log("foo is: " + localStorage.foo);
     36    log("foo (after a delete) is: " + localStorage.foo);
     37    delete localStorage.foo;
     38    log("foo (after a redundant delete) is: " + localStorage.foo);
     39    localStorage.foo = "bar";
     40    log("foo (after an implicit settter set) is: " + localStorage.foo);
     41    delete localStorage["foo"];
     42    log("foo (after an indexed delete) is: " + localStorage.foo);
    3543}
    3644

  • trunk/LayoutTests/storage/domstorage/localstorage/enumerate-storage.html

    r46314 r46498  
    1010{
    1111    document.getElementById("logger").innerHTML += a + "<br>";
    12 }
    13 
    14 function finish()
    15 {
    16     if (window.layoutTestController)
    17         layoutTestController.notifyDone()
    1812}
    1913

  • trunk/LayoutTests/storage/domstorage/localstorage/enumerate-with-length-and-key.html

    r46402 r46498  
    1010{
    1111    document.getElementById("logger").innerHTML += a + "<br>";
    12 }
    13 
    14 function finish()
    15 {
    16     if (window.layoutTestController)
    17         layoutTestController.notifyDone()
    1812}
    1913
    … …  
    3529    // Enumerate localStorage, appending each key onto an array
    3630    var enumeratedArray = new Array();
    37     for (var n in localStorage)
    38         enumeratedArray.push(n);
     31    for (var i=0; i<localStorage.length; ++i)
     32        enumeratedArray.push(localStorage.key(i));
    3933
    4034    // Sort the array, since the storage order isn't guaranteed
    … …  
    4842</head>
    4943<body onload="startTest();">
    50 This test checks to see that you can enumerate a Storage object and get only the keys as a result.  The built-in properties of the Storage object should be ignored.  The test operates on the localStorage object.<br>
     44This test attempts to enumerate all the keys in localStorage with .length + .key().  The built-in properties of the Storage object should be ignored.  The test operates on the localStorage object.<br>
    5145<div id="logger"></div>
    5246</body>

  • trunk/LayoutTests/storage/domstorage/localstorage/iframe-events-expected.txt

    r44481 r46498  
    11This is the main frame of a 2-frame document. Each frame is in the same security origin and therefore shares the same localStorage object. As a result, each frame should receive a StorageEvent when either frame changes the localStorage object.
    22
    3 Main frame about to change localStorage...
     3Main frame about to run setItem on localStorage...
    44Main Frame received StorageEvent:
    55Key - Main Frame
    … …  
    3535Storage Area - This window's window.localStorage
    3636
     37Main frame about to run removeItem on localStorage...
     38Main Frame received StorageEvent:
     39Key - Main Frame
     40New Value - null
     41Old Value - SET
     42URI - LayoutTests/storage/domstorage/localstorage/iframe-events.html
     43Source - LayoutTests/storage/domstorage/localstorage/iframe-events.html
     44Storage Area - This window's window.localStorage
    3745
     46Subframe received storage event:
     47Key - Main Frame
     48New Value - null
     49Old Value - SET
     50URI - LayoutTests/storage/domstorage/localstorage/iframe-events.html
     51Source - LayoutTests/storage/domstorage/localstorage/iframe-events.html
     52Storage Area - This window's window.localStorage
     53
     54Subframe about to change localStorage...
     55Main frame about to clear localStorage...
     56Main Frame received StorageEvent:
     57Key -
     58New Value - null
     59Old Value - null
     60URI - LayoutTests/storage/domstorage/localstorage/iframe-events.html
     61Source - LayoutTests/storage/domstorage/localstorage/iframe-events.html
     62Storage Area - This window's window.localStorage
     63
     64Subframe received storage event:
     65Key -
     66New Value - null
     67Old Value - null
     68URI - LayoutTests/storage/domstorage/localstorage/iframe-events.html
     69Source - LayoutTests/storage/domstorage/localstorage/iframe-events.html
     70Storage Area - This window's window.localStorage
     71
     72Subframe about to change localStorage...
     73Main Frame received StorageEvent:
     74Key - Subframe
     75New Value - SET
     76Old Value - null
     77URI - LayoutTests/storage/domstorage/localstorage/resources/iframe-events-second.html
     78Source - LayoutTests/storage/domstorage/localstorage/resources/iframe-events-second.html
     79Storage Area - This window's window.localStorage
     80
     81Subframe received storage event:
     82Key - Subframe
     83New Value - SET
     84Old Value - null
     85URI - LayoutTests/storage/domstorage/localstorage/resources/iframe-events-second.html
     86Source - LayoutTests/storage/domstorage/localstorage/resources/iframe-events-second.html
     87Storage Area - This window's window.localStorage
     88
     89

  • trunk/LayoutTests/storage/domstorage/localstorage/iframe-events.html

    r44481 r46498  
    4949
    5050    window.addEventListener("storage", handleStorageEvent, false);
    51     log("Main frame about to change localStorage...");
     51    log("Main frame about to run setItem on localStorage...");
    5252    localStorage.setItem("Main Frame", "SET");
     53    log("Main frame about to run removeItem on localStorage...");
     54    localStorage.removeItem("Main Frame");
     55    log("Main frame about to clear localStorage...");
     56    localStorage.clear();
    5357}
    5458

  • trunk/LayoutTests/storage/domstorage/localstorage/onstorage-attribute-setwindow-expected.txt

    r46402 r46498  
    1 This is a test to make sure LocalStorage mutations fire StorageEvents that are caught by the event listener corresponding to body.onstorage. The event listener is setup via body.setAttribute().
     1This is a test to make sure LocalStorage mutations fire StorageEvents that are caught by the event listener corresponding to window.onstorage.
    22Storage event fired:
    33Key - FOO

  • trunk/LayoutTests/storage/domstorage/localstorage/onstorage-attribute-setwindow.html

    r46402 r46498  
    3232        return;
    3333    }
    34    
    35     document.body.setAttribute("onstorage", "handleStorageEvent();");
     34
     35    window.onstorage = handleStorageEvent;
    3636   
    3737    window.localStorage.setItem("FOO", "BAR");
    … …  
    4444</head>
    4545<body onload="runTest();">
    46 This is a test to make sure LocalStorage mutations fire StorageEvents that are caught by the event listener corresponding to body.onstorage.  The event listener is setup via body.setAttribute().<br>
     46This is a test to make sure LocalStorage mutations fire StorageEvents that are caught by the event listener corresponding to window.onstorage.<br>
    4747<div id="logger"></div>
    4848</body>

  • trunk/LayoutTests/storage/domstorage/window-attributes-exist-expected.txt

    r44301 r46498  
    66Storage object sessionStorage has setItem
    77Storage object sessionStorage has removeItem
     8Storage object sessionStorage has clear
     9window.sessionStorage == window.sessionStorage: true
     10window.sessionStorage === window.sessionStorage: true
    811window.localStorage exists
    912Storage object localStorage has length
    … …  
    1215Storage object localStorage has setItem
    1316Storage object localStorage has removeItem
     17Storage object localStorage has clear
     18window.localStorage == window.localStorage: true
     19window.localStorage === window.localStorage: true
    1420window.onstorage exists
    1521The onstorage property works when a storage event is fired.

  • trunk/LayoutTests/storage/domstorage/window-attributes-exist.html

    r46314 r46498  
    2323    if ("removeItem" in storage)
    2424        log("Storage object " + name + " has removeItem");
     25    if ("clear" in storage)
     26        log("Storage object " + name + " has clear");
    2527}
    2628
    … …  
    4042        log("window.sessionStorage exists");
    4143        testStorage("sessionStorage", window.sessionStorage);
     44        log("window.sessionStorage == window.sessionStorage: " + (window.sessionStorage == window.sessionStorage));
     45        log("window.sessionStorage === window.sessionStorage: " + (window.sessionStorage === window.sessionStorage));
    4246    } else
    4347        log("window.sessionStorage DOES NOT exist");
    … …  
    4650        log("window.localStorage exists");
    4751        testStorage("localStorage", window.localStorage);
     52        log("window.localStorage == window.localStorage: " + (window.localStorage == window.localStorage));
     53        log("window.localStorage === window.localStorage: " + (window.localStorage === window.localStorage));
    4854    } else
    4955        log("window.localStorage DOES NOT exist");
Note: See TracChangeset for help on using the changeset viewer.