Changeset 46600 in webkit


Ignore:
Timestamp:
Jul 30, 2009 2:16:03 PM (15 years ago)
Author:
treat@webkit.org
Message:

WebCore:
2009-07-30 Mike Fenton <​mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Apply colour style to buttons that use Theme settings in Qt.

​https://bugs.webkit.org/show_bug.cgi?id=27814

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::adjustButtonStyle):

LayoutTests:
2009-07-30 Mike Fenton <​mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Add Button Colour style test and results for Qt based upon fix for bug.
Unskip tables/mozilla/bugs/bug92647-2.html which passes with bug fix.
Update expected results for qt for test fast/dom/HTMLTableColElement/resize-table-using-col-width-expected
which also passes with the the bug fix.

​https://bugs.webkit.org/show_bug.cgi?id=27814

  • fast/forms/button-style-color.html: Added.
  • platform/qt/Skipped:
  • platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
  • platform/qt/fast/forms/button-style-color-expected.txt: Added.
Location:
trunk
Files:
2 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r46581 r46600  
     12009-07-30  Mike Fenton  <mike.fenton@torchmobile.com>
     2
     3         Reviewed by Adam Treat.
     4
     5         Add Button Colour style test and results for Qt based upon fix for bug.
     6         Unskip tables/mozilla/bugs/bug92647-2.html which passes with bug fix.
     7         Update expected results for qt for test fast/dom/HTMLTableColElement/resize-table-using-col-width-expected
     8         which also passes with the the bug fix.
     9
     10         https://bugs.webkit.org/show_bug.cgi?id=27814
     11
     12         * fast/forms/button-style-color.html: Added.
     13         * platform/qt/Skipped:
     14         * platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
     15         * platform/qt/fast/forms/button-style-color-expected.txt: Added.
     16
    1172009-07-30  Eric Carlson  <eric.carlson@apple.com>
    218

  • trunk/LayoutTests/platform/qt/Skipped

    r46529 r46600  
    44254425tables/mozilla/bugs/bug9123-2.html
    44264426tables/mozilla/bugs/bug92143.html
    4427 tables/mozilla/bugs/bug92647-2.html
    44284427tables/mozilla/bugs/bug9271-1.html
    44294428tables/mozilla/bugs/bug9271-2.html

  • trunk/LayoutTests/platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt

    r46278 r46600  
    3131                text run at (2,2) width 63: "col 3 row 3"
    3232      RenderBlock (anonymous) at (0,50) size 784x32
    33         RenderButton {BUTTON} at (2,2) size 393x28 [color=#1A1A1A] [bgcolor=#C0C0C0]
     33        RenderButton {BUTTON} at (2,2) size 393x28 [bgcolor=#C0C0C0]
    3434          RenderBlock (anonymous) at (6,6) size 381x17
    3535            RenderText {#text} at (0,0) size 381x17

  • trunk/WebCore/ChangeLog

    r46598 r46600  
     12009-07-30  Mike Fenton  <mike.fenton@torchmobile.com>
     2
     3         Reviewed by Adam Treat.
     4
     5         Apply colour style to buttons that use Theme settings in Qt.
     6
     7         https://bugs.webkit.org/show_bug.cgi?id=27814
     8
     9         * platform/qt/RenderThemeQt.cpp:
     10         (WebCore::RenderThemeQt::adjustButtonStyle):
     11
    112=== End merge of nitro-extreme branch 2009-07-30 ===
    213

  • trunk/WebCore/platform/qt/RenderThemeQt.cpp

    r46170 r46600  
    420420    setButtonSize(style);
    421421    setButtonPadding(style);
    422 
    423     style->setColor(QApplication::palette().text().color());
    424422}
    425423
Note: See TracChangeset for help on using the changeset viewer.