Changeset 47049 in webkit

Timestamp:

Aug 11, 2009 12:37:38 PM (15 years ago)

Author:

eric@webkit.org

Message:

2009-08-11 Joseph Pecoraro <​joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Console Drawer is Toggling instead of Staying Open
​https://bugs.webkit.org/show_bug.cgi?id=28115

• inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype.showView): ensures the drawer will be open and showing the provided view
• inspector/front-end/inspector.js: (WebInspector.showConsole): usees the new showView to guarantee the Drawer will be open (WebInspector.showChanges): uses the new showView guarantee the Drawer will be open

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/Drawer.js (modified) (1 diff)
• inspector/front-end/inspector.js (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-08-11  Joseph Pecoraro  <joepeck02@gmail.com>
+
+        Reviewed by Timothy Hatcher.
+
+        Inspector: Console Drawer is Toggling instead of Staying Open
+        https://bugs.webkit.org/show_bug.cgi?id=28115
+
+        * inspector/front-end/Drawer.js:
+        (WebInspector.Drawer.prototype.showView): ensures the drawer will be open and showing the provided view
+        * inspector/front-end/inspector.js:
+        (WebInspector.showConsole): usees the new showView to guarantee the Drawer will be open
+        (WebInspector.showChanges): uses the new showView guarantee the Drawer will be open
+
 2009-08-11  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
 

trunk/WebCore/inspector/front-end/Drawer.js

@@ -65 +65 @@
     },
 
+    showView: function(view)
+    {
+        if (!this.visible || this.visibleView !== view)
+            this.visibleView = view;
+    },
+
     show: function()
     {

trunk/WebCore/inspector/front-end/inspector.js

@@ -854 +854 @@
 WebInspector.showConsole = function()
 {
-    this.drawer.visibleView = this.console;
+    this.drawer.showView(this.console);
 }
 
 WebInspector.showChanges = function()
 {
-    this.drawer.visibleView = this.changes;
+    this.drawer.showView(this.changes);
 }