Changeset 47166 in webkit

Timestamp:

Aug 12, 2009 5:03:52 PM (15 years ago)

Author:

eric@webkit.org

Message:

2009-08-11 Eric Seidel <​eric@webkit.org>

Reviewed by Mark Rowe.

bugzilla-tool : various improvements for running the commit-queue
​https://bugs.webkit.org/show_bug.cgi?id=28199

Make run_and_throw_if_fail silence STDERR as well as STDIN.
I also changed run_and_throw_if_fail to use the /dev/null trick instead of .communicate() to avoid ever buffering the output (per abarth's suggestion).
Change a few "print" statements to "log" so they appear in the output.
Changed all string + uses to use string formatting instead (this is less error prone as it will automatically convert non-string objects).
Added a little more logging so that --quiet mode is easier to understand.
Changed clear_attachment_review_flag to clear_attachment_flags and made it clear the commit-queue flag as well.
Added the ability for bugzilla-tool to reject patches from the commit-queue when they fail to compile/apply/etc.
Added _find_select_element_for_flag to make the code for finding flag <select> elements clearer.
Made curl call (downloading patch files) quieter.

• Scripts/bugzilla-tool:
• Scripts/modules/bugzilla.py:
• Scripts/modules/scm.py:

<<<<<<< HEAD:WebKitTools/ChangeLog

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (2 diffs)
• Scripts/bugzilla-tool (modified) (1 diff)
• Scripts/run-webkit-tests (modified) (4 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-08-11  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Mark Rowe.
+
+        bugzilla-tool : various improvements for running the commit-queue
+        https://bugs.webkit.org/show_bug.cgi?id=28199
+
+        Make run_and_throw_if_fail silence STDERR as well as STDIN.
+        I also changed run_and_throw_if_fail to use the /dev/null trick instead of .communicate() to avoid ever buffering the output (per abarth's suggestion).
+        Change a few "print" statements to "log" so they appear in the output.
+        Changed all string + uses to use string formatting instead (this is less error prone as it will automatically convert non-string objects).
+        Added a little more logging so that --quiet mode is easier to understand.
+        Changed clear_attachment_review_flag to clear_attachment_flags and made it clear the commit-queue flag as well.
+        Added the ability for bugzilla-tool to reject patches from the commit-queue when they fail to compile/apply/etc.
+        Added _find_select_element_for_flag to make the code for finding flag <select> elements clearer.
+        Made curl call (downloading patch files) quieter.
+
+        * Scripts/bugzilla-tool:
+        * Scripts/modules/bugzilla.py:
+        * Scripts/modules/scm.py:
+
+<<<<<<< HEAD:WebKitTools/ChangeLog
 2009-08-12  Peter Kasting  <pkasting@google.com>
 
@@ -12 +34 @@
         * Scripts/svn-create-patch:
         * Scripts/update-webkit:
+=======
+2009-08-12  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Mark Rowe.
+
+        run-webkit-tests needs a --exit-after-failures=N option
+        https://bugs.webkit.org/show_bug.cgi?id=28192
+
+        Added the option and deployed it to bugzilla-tool.
+
+        * Scripts/bugzilla-tool:
+        * Scripts/run-webkit-tests:
+>>>>>>> 2009-08-12  Eric Seidel  <eric@webkit.org>:WebKitTools/ChangeLog
 
 2009-08-12  Kevin Ollivier  <kevino@theolliviers.com>

trunk/WebKitTools/Scripts/bugzilla-tool

@@ -276 +276 @@
          if quiet:
              args.append("--quiet")
+         # When landing patches we almost always want to fail as fast as possible.
+         args.append("--exit-after-n-failures=1")
          cls.run_and_throw_if_fail(args)
 

trunk/WebKitTools/Scripts/run-webkit-tests

@@ -110 +110 @@
 my $addPlatformExceptions = 0;
 my $complexText = 0;
+my $exitAfterNFailures = 0;
 my $guardMalloc = '';
 my $httpdPort = 8000;
@@ -194 +195 @@
   -c|--configuration config       Set DumpRenderTree build configuration
   -g|--guard-malloc               Enable malloc guard
+  --exit-after-n-failures N       Exit after the first N failures instead of running all tests
   --help                          Show this help message
   --[no-]http                     Run (or do not run) http tests (default: $httpDefault)
@@ -231 +233 @@
 my $getOptionsResult = GetOptions(
     'complex-text' => \$complexText,
+    'exit-after-n-failures=i' => \$exitAfterNFailures,
     'guard-malloc|g' => \$guardMalloc,
     'help' => \$showHelp,
@@ -992 +995 @@
 
     countFinishedTest($test, $base, $result, $isText);
+
+    my $failureCount = $count - $counts{match}; # Includes new tests, timeouts, crashes, etc.
+    if ($exitAfterNFailures && $failureCount >= $exitAfterNFailures) {
+        print "\nExiting early after $failureCount failures.  $count tests run.";
+        closeDumpTool();
+        last;
+    }
 }
 printf "\n%0.2fs total testing time\n", (time - $overallStartTime) . "";