Changeset 47211 in webkit

Timestamp:

Aug 13, 2009, 10:52:26 AM (16 years ago)

Author:

eric@webkit.org

Message:

2009-08-13 Dirk Schulze <​krit@webkit.org>

Reviewed by Eric Seidel.

[CAIRO] getImageData fails on a given rect bigger than the image rect

The destination image and the source image was mixed up on creating the
imageData.

This is just a clean up and doesn't affect the current behavior. It's not
possible to test this failure in a LayoutTest. Only canvas uses getImageData
at the moment and returns before calling getImageData, if the image rect does
not contain the requested rect.

• platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::getImageData):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/cairo/ImageBufferCairo.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-08-13  Dirk Schulze  <krit@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        [CAIRO] getImageData fails on a given rect bigger than the image rect
+
+        The destination image and the source image was mixed up on creating the
+        imageData.
+
+        This is just a clean up and doesn't affect the current behavior. It's not
+        possible to test this failure in a LayoutTest. Only canvas uses getImageData
+        at the moment and returns before calling getImageData, if the image rect does
+        not contain the requested rect.
+
+        * platform/graphics/cairo/ImageBufferCairo.cpp:
+        (WebCore::getImageData):
+
 2009-08-13  Maxime Simon  <simon.maxime@gmail.com>
 

trunk/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp

@@ -149 +149 @@
 
     if (rect.x() < 0 || rect.y() < 0 || (rect.x() + rect.width()) > size.width() || (rect.y() + rect.height()) > size.height())
-        memset(dataSrc, 0, result->data()->length());
+        memset(dataDst, 0, result->data()->length());
 
     int originx = rect.x();