Changeset 47247 in webkit

Timestamp:

Aug 13, 2009 3:48:25 PM (15 years ago)

Author:

ajwong@chromium.org

Message:

Chromium: Show a "Playback Disabled" button on media error.
​https://bugs.webkit.org/show_bug.cgi?id=28196
Use a disabled play button when the media file cannot be played.

Patch by Kyle Prete <​kylep@chromium.org> on 2009-08-13
Reviewed by Dave Levin.

No new tests needed. Covered by LayoutTests/media/video-empty-source.html

• rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::paintMediaPlayButton):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderThemeChromiumSkia.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-08-13  Kyle Prete  <kylep@chromium.org>
+
+        Reviewed by Dave Levin.
+
+        Chromium: Show a "Playback Disabled" button on media error.
+        https://bugs.webkit.org/show_bug.cgi?id=28196
+        Use a disabled play button when the media file cannot be played.
+
+        No new tests needed. Covered by LayoutTests/media/video-empty-source.html
+
+        * rendering/RenderThemeChromiumSkia.cpp:
+        (WebCore::RenderThemeChromiumSkia::paintMediaPlayButton):
+
 2009-08-13  Mark Rowe  <mrowe@apple.com>
 

trunk/WebCore/rendering/RenderThemeChromiumSkia.cpp

@@ -611 +611 @@
     static Image* mediaPlay = Image::loadPlatformResource("mediaPlay").releaseRef();
     static Image* mediaPause = Image::loadPlatformResource("mediaPause").releaseRef();
+    static Image* mediaPlayDisabled = Image::loadPlatformResource("mediaPlayDisabled").releaseRef();
+
+    if (mediaElement->networkState() == HTMLMediaElement::NETWORK_NO_SOURCE)
+        return paintMediaButtonInternal(paintInfo.context, rect, mediaPlayDisabled);
 
     return paintMediaButtonInternal(paintInfo.context, rect, mediaElement->paused() ? mediaPlay : mediaPause);