Changeset 47546 in webkit


Ignore:
Timestamp:
Aug 19, 2009 8:51:53 PM (15 years ago)
Author:
jorlow@chromium.org
Message:

2009-08-19 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Disable a bad SKIA assert
https://bugs.webkit.org/show_bug.cgi?id=28482

In http://trac.webkit.org/changeset/47386/ an assert was "fixed" in SKIA code.
When this was pulled into Chromium, it started breaking the page cycler.
Disable it again until we can figure out what's going on.

  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintCommon):
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r47541 r47546  
     12009-08-19  Jeremy Orlow  <jorlow@chromium.org>
     2
     3        Reviewed by Darin Fisher.
     4
     5        Disable a bad SKIA assert
     6        https://bugs.webkit.org/show_bug.cgi?id=28482
     7
     8        In http://trac.webkit.org/changeset/47386/ an assert was "fixed" in SKIA code.
     9        When this was pulled into Chromium, it started breaking the page cycler.
     10        Disable it again until we can figure out what's going on.
     11
     12        * platform/graphics/skia/PlatformContextSkia.cpp:
     13        (PlatformContextSkia::setupPaintCommon):
     14
    1152009-08-19  Ryosuke Niwa  <rniwa@webkit.org>
    216
  • trunk/WebCore/platform/graphics/skia/PlatformContextSkia.cpp

    r47386 r47546  
    296296void PlatformContextSkia::setupPaintCommon(SkPaint* paint) const
    297297{
    298 #ifdef SK_DEBUG
     298    // http://trac.webkit.org/changeset/47386/ re-enabled this assert and it
     299    // immediately started being hit in page cycler code.
     300    // FIXME: Re-enable it.
     301#if defined(SK_DEBUG) && 0
    299302    {
    300303        SkPaint defaultPaint;
Note: See TracChangeset for help on using the changeset viewer.