Changeset 48830 in webkit

Timestamp:

Sep 28, 2009 1:42:15 PM (15 years ago)

Author:

oliver@apple.com

Message:

Hard dependency on SSE2 instruction set with JIT
​https://bugs.webkit.org/show_bug.cgi?id=29779

Reviewed by Geoff Garen

Add floating point support checks to op_jfalse and op_jtrue, and
fix the logic for the slow case of op_add

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• jit/JITArithmetic.cpp (modified) (1 diff)
• jit/JITOpcodes.cpp (modified) (2 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2009-09-28  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by Geoff Garen.
+
+        Hard dependency on SSE2 instruction set with JIT
+        https://bugs.webkit.org/show_bug.cgi?id=29779
+
+        Add floating point support checks to op_jfalse and op_jtrue, and
+        fix the logic for the slow case of op_add
+
+        * jit/JITArithmetic.cpp:
+        (JSC::JIT::emitSlow_op_add):
+        * jit/JITOpcodes.cpp:
+        (JSC::JIT::emit_op_jfalse):
+        (JSC::JIT::emit_op_jtrue):
+
 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
 

trunk/JavaScriptCore/jit/JITArithmetic.cpp

@@ -636 +636 @@
         linkSlowCase(iter); // overflow check
 
-        if (!supportsFloatingPoint()) {
+        if (!supportsFloatingPoint())
             linkSlowCase(iter); // non-sse case
-            return;
-        }
-
-        ResultType opType = op == op1 ? types.first() : types.second();
-        if (!opType.definitelyIsNumber())
-            linkSlowCase(iter); // double check
+        else {
+            ResultType opType = op == op1 ? types.first() : types.second();
+            if (!opType.definitelyIsNumber())
+                linkSlowCase(iter); // double check
+        }
     } else {
         linkSlowCase(iter); // overflow check

trunk/JavaScriptCore/jit/JITOpcodes.cpp

@@ -795 +795 @@
     addJump(jump(), target + 2);
 
-    isNotInteger.link(this);
-
-    addSlowCase(branch32(Above, regT1, Imm32(JSValue::LowestTag)));
-
-    zeroDouble(fpRegT0);
-    emitLoadDouble(cond, fpRegT1);
-    addJump(branchDouble(DoubleEqual, fpRegT0, fpRegT1), target + 2);
-    
+    if (supportsFloatingPoint()) {
+        isNotInteger.link(this);
+
+        addSlowCase(branch32(Above, regT1, Imm32(JSValue::LowestTag)));
+
+        zeroDouble(fpRegT0);
+        emitLoadDouble(cond, fpRegT1);
+        addJump(branchDouble(DoubleEqual, fpRegT0, fpRegT1), target + 2);
+    } else
+        addSlowCase(isNotInteger);
+
     isTrue.link(this);
     isTrue2.link(this);
@@ -833 +836 @@
     addJump(jump(), target + 2);
 
-    isNotInteger.link(this);
-
-    addSlowCase(branch32(Above, regT1, Imm32(JSValue::LowestTag)));
-
-    zeroDouble(fpRegT0);
-    emitLoadDouble(cond, fpRegT1);
-    addJump(branchDouble(DoubleNotEqual, fpRegT0, fpRegT1), target + 2);
-    
+    if (supportsFloatingPoint()) {
+        isNotInteger.link(this);
+
+        addSlowCase(branch32(Above, regT1, Imm32(JSValue::LowestTag)));
+
+        zeroDouble(fpRegT0);
+        emitLoadDouble(cond, fpRegT1);
+        addJump(branchDouble(DoubleNotEqual, fpRegT0, fpRegT1), target + 2);
+    } else
+        addSlowCase(isNotInteger);
+
     isFalse.link(this);
     isFalse2.link(this);