Changeset 48858 in webkit

Timestamp:

Sep 28, 2009 10:16:58 PM (15 years ago)

Author:

xan@webkit.org

Message:

2009-09-29 Xan Lopez <​xlopez@igalia.com>

Rubber-stamped by Eric Seidel.

[Gtk] Crash when saving a password
​https://bugs.webkit.org/show_bug.cgi?id=28070

Disconnect the 'got-headers' callback when we are done with
it. The signal can be emitted more than once if the message is
retransmitted, but each time that happens authData is created
again and a new callback connected, so we have to get rid of the
old one (which will crash because we free authData).

• webkit/webkitsoupauthdialog.c: (save_password_callback):

Location:

trunk/WebKit/gtk

Files:

• ChangeLog (modified) (1 diff)
• webkit/webkitsoupauthdialog.c (modified) (1 diff)

trunk/WebKit/gtk/ChangeLog

@@ +1 @@
+2009-09-29  Xan Lopez  <xlopez@igalia.com>
+
+        Rubber-stamped by Eric Seidel.
+
+        [Gtk] Crash when saving a password
+        https://bugs.webkit.org/show_bug.cgi?id=28070
+
+        Disconnect the 'got-headers' callback when we are done with
+        it. The signal can be emitted more than once if the message is
+        retransmitted, but each time that happens authData is created
+        again and a new callback connected, so we have to get rid of the
+        old one (which will crash because we free authData).
+
+        * webkit/webkitsoupauthdialog.c:
+        (save_password_callback):
+
 2009-09-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 

trunk/WebKit/gtk/webkit/webkitsoupauthdialog.c

@@ -108 +108 @@
         soup_auth_save_password(authData->auth, authData->username, authData->password);
 
+    /* Disconnect the callback. If the authentication succeeded we are
+     * done, and if it failed we'll create a new authData and we'll
+     * connect to 'got-headers' again in response_callback */
+    g_signal_handlers_disconnect_by_func(msg, save_password_callback, authData);
+
     free_authData(authData);
 }