Changeset 48916 in webkit

Timestamp:

Sep 29, 2009 6:46:26 PM (15 years ago)

Author:

eric@webkit.org

Message:

2009-09-29 Yaar Schnitman <​yaar@chromium.org>

Reviewed by David Kilzer.

Fixed how error codes are handled.
​https://bugs.webkit.org/show_bug.cgi?id=29898

• Scripts/update-webkit:
• Scripts/update-webkit-chromium:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/update-webkit (modified) (1 diff)
• Scripts/update-webkit-chromium (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-09-29  Yaar Schnitman  <yaar@chromium.org>
+
+        Reviewed by David Kilzer.
+
+        Fixed how error codes are handled.
+        https://bugs.webkit.org/show_bug.cgi?id=29898
+
+        * Scripts/update-webkit:
+        * Scripts/update-webkit-chromium:
+
 2009-09-29  Brady Eidson  <beidson@apple.com>
 

trunk/WebKitTools/Scripts/update-webkit

@@ -78 +78 @@
     runSvnUpdate();
 } elsif (isChromium()) {
-    system("perl", "WebKitTools/Scripts/update-webkit-chromium") == 0 or die;
+    system("perl", "WebKitTools/Scripts/update-webkit-chromium") == 0 or die $!;
 } elsif (isAppleWinWebKit()) {
     system("perl", "WebKitTools/Scripts/update-webkit-auxiliary-libs") == 0 or die;

trunk/WebKitTools/Scripts/update-webkit-chromium

@@ -38 +38 @@
 }
 
-# If .gclient configuration file doesn't exist, create it.
 chdir("WebKit/chromium") or die $!;
 if (! -e ".gclient") {
+    # If .gclient configuration file doesn't exist, create it.
     print "Configuring gclient...\n";
-    my $result = exec("gclient", 
-                        "config", 
-                        "--spec=solutions=[{'name':'./','url':None}]");
-    if (!$result) {
-        die "Error while configuring gclient for chromium port\n";
-    }
+    system("gclient", 
+           "config", 
+           "--spec=solutions=[{'name':'./','url':None}]") == 0 or die $!;
 }
 
 # Execute gclient sync.
 print "Updating chromium port dependencies using gclient...\n";
-exec("gclient", "sync") == 0 or die;
+system("gclient", "sync") == 0 or die $!;