Changeset 48973 in webkit

Timestamp:

Oct 1, 2009 8:26:41 AM (15 years ago)

Author:

eric@webkit.org

Message:

2009-10-01 Dumitru Daniliuc <​dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Read-only transactions do not change file sizes and therefore
should not trigger quota updates.

​https://bugs.webkit.org/show_bug.cgi?id=29945

• storage/SQLTransaction.cpp: (WebCore::SQLTransaction::openTransactionAndPreflight): (WebCore::SQLTransaction::runStatements):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• storage/SQLTransaction.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-10-01  Dumitru Daniliuc  <dumi@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        Read-only transactions do not change file sizes and therefore
+        should not trigger quota updates.
+
+        https://bugs.webkit.org/show_bug.cgi?id=29945
+
+        * storage/SQLTransaction.cpp:
+        (WebCore::SQLTransaction::openTransactionAndPreflight):
+        (WebCore::SQLTransaction::runStatements):
+
 2009-09-30  Timothy Hatcher  <timothy@apple.com>
 

trunk/WebCore/storage/SQLTransaction.cpp

@@ -233 +233 @@
     }
 
-    // Set the maximum usage for this transaction
-    m_database->m_sqliteDatabase.setMaximumSize(m_database->maximumSize());
+    // Set the maximum usage for this transaction if this transactions is not read-only
+    if (!m_readOnly)
+        m_database->m_sqliteDatabase.setMaximumSize(m_database->maximumSize());
 
     ASSERT(!m_sqliteTransaction);
@@ -308 +309 @@
             // See ::openTransactionAndPreflight() for discussion
 
-            // Reset the maximum size here, as it was increased to allow us to retry this statement
+            // Reset the maximum size here, as it was increased to allow us to retry this statement.
+            // m_shouldRetryCurrentStatement is set to true only when a statement exceeds
+            // the quota, which can happen only in a read-write transaction. Therefore, there
+            // is no need to check here if the transaction is read-write.
             m_database->m_sqliteDatabase.setMaximumSize(m_database->maximumSize());
         } else {