Changeset 49039 in webkit

Timestamp:

Oct 2, 2009 1:09:02 PM (15 years ago)

Author:

Joseph Pecoraro

Message:

2009-10-02 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Database Inspector crashes Safari when table has more than 21 columns
​https://bugs.webkit.org/show_bug.cgi?id=29924

• inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.dataGridForResult): adjust the minimum column width percentage to be flexible for many columns.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/StoragePanel.js (modified) (3 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-10-02  Joseph Pecoraro  <joepeck@webkit.org>
+
+        Reviewed by Timothy Hatcher.
+
+        Database Inspector crashes Safari when table has more than 21 columns
+        https://bugs.webkit.org/show_bug.cgi?id=29924
+
+        * inspector/front-end/StoragePanel.js:
+        (WebInspector.StoragePanel.prototype.dataGridForResult): adjust the minimum column width percentage to be flexible for many columns.
+
 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
 

trunk/WebCore/inspector/front-end/StoragePanel.js

@@ -304 +304 @@
 
         var columns = {};
+        var numColumns = 0;
 
         var rows = result.rows;
@@ -312 +313 @@
 
             columns[columnIdentifier] = column;
+            ++numColumns;
         }
 
@@ -340 +342 @@
 
         // Calculate the percentage width for the columns.
-        const minimumPrecent = 5;
+        const minimumPrecent = Math.min(5, Math.floor(100/numColumns));
         var recoupPercent = 0;
         for (var columnIdentifier in columns) {