Changeset 49294 in webkit


Ignore:
Timestamp:
Oct 8, 2009 6:09:46 AM (15 years ago)
Author:
Simon Hausmann
Message:

Part of testOptionalJSObjects autotest was marked as "expect to fail".

Patch by Jedrzej Nowacki <​jedrzej.nowacki@nokia.com> on 2009-10-08
Reviewed by Simon Hausmann.

Two places in tst_QWebPage::testOptionalJSObjects were marked as
expected to fail. The problem concern checking if a feature is enabled
or disabled. According to discussion on webkit dev mailing list
a disabled feature should be invisible from java script level, but
there are exceptions from the rule. So we decided to disable the test
for now.

​https://bugs.webkit.org/show_bug.cgi?id=29867

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::testOptionalJSObjects):

Location:
trunk/WebKit/qt
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKit/qt/ChangeLog

    r49284 r49294  
     12009-10-08  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
     2
     3        Reviewed by Simon Hausmann.
     4
     5        Part of testOptionalJSObjects autotest was marked as "expect to fail".
     6
     7        Two places in tst_QWebPage::testOptionalJSObjects were marked as
     8        expected to fail. The problem concern checking if a feature is enabled
     9        or disabled. According to discussion on webkit dev mailing list
     10        a disabled feature should be invisible from java script level, but
     11        there are exceptions from the rule. So we decided to disable the test
     12        for now.
     13
     14        https://bugs.webkit.org/show_bug.cgi?id=29867
     15
     16        * tests/qwebpage/tst_qwebpage.cpp:
     17        (tst_QWebPage::testOptionalJSObjects):
     18
    1192009-10-07  Adam Barth  <abarth@webkit.org>
    220

  • trunk/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp

    r49100 r49294  
    13591359    webPage2.currentFrame()->setHtml(QString("<html><body>test</body></html>"), QUrl());
    13601360
     1361    QEXPECT_FAIL("","Feature enabled/disabled checking problem. Look at bugs.webkit.org/show_bug.cgi?id=29867", Continue);
    13611362    QCOMPARE(testFlag(webPage1, QWebSettings::OfflineWebApplicationCacheEnabled, "applicationCache", false), false);
    13621363    QCOMPARE(testFlag(webPage2, QWebSettings::OfflineWebApplicationCacheEnabled, "applicationCache", true),  true);
     1364    QEXPECT_FAIL("","Feature enabled/disabled checking problem. Look at bugs.webkit.org/show_bug.cgi?id=29867", Continue);
    13631365    QCOMPARE(testFlag(webPage1, QWebSettings::OfflineWebApplicationCacheEnabled, "applicationCache", false), false);
    13641366    QCOMPARE(testFlag(webPage2, QWebSettings::OfflineWebApplicationCacheEnabled, "applicationCache", false), true);
Note: See TracChangeset for help on using the changeset viewer.