Changeset 49730 in webkit

Timestamp:

Oct 16, 2009 8:54:56 PM (15 years ago)

Author:

tonikitoo@webkit.org

Message:

[Qt] QGLauncher leaks WebPage object
​https://bugs.webkit.org/show_bug.cgi?id=30465

Patch by Antonio Gomes <​tonikitoo@webkit.org> on 2009-10-16
Reviewed by Simon Hausmann.

Make 'SharedScene' to own 'WebPage' reference and delete it at its destructor.

• Api/qwebpage.cpp:

(QWebPage::view):

• Api/qwebpage_p.h:
• QGVLauncher/main.cpp:

(SharedScene::SharedScene):
(SharedScene::~SharedScene):

Location:

trunk/WebKit/qt

Files:

• ChangeLog (modified) (1 diff)
• QGVLauncher/main.cpp (modified) (3 diffs)

trunk/WebKit/qt/ChangeLog

@@ +1 @@
+2009-10-16  Antonio Gomes  <tonikitoo@webkit.org>
+
+        Reviewed by Simon Hausmann.
+
+        [Qt] QGLauncher leaks WebPage object
+        https://bugs.webkit.org/show_bug.cgi?id=30465
+
+        Make 'SharedScene' to own 'WebPage' reference and delete it at its destructor.
+
+        * Api/qwebpage.cpp:
+        (QWebPage::view):
+        * Api/qwebpage_p.h:
+        * QGVLauncher/main.cpp:
+        (SharedScene::SharedScene):
+        (SharedScene::~SharedScene):
+
 2009-10-16  Antonio Gomes  <tonikitoo@webkit.org>
 

trunk/WebKit/qt/QGVLauncher/main.cpp

@@ -126 +126 @@
     {
         m_scene = new QGraphicsScene;
-
         m_item = new QGraphicsWebView;
-        m_item->setPage(new WebPage());
+        m_item->setPage((m_page = new WebPage));
 
         m_scene->addItem(m_item);
@@ -138 +137 @@
         delete m_item;
         delete m_scene;
+        delete m_page;
     }
 
@@ -146 +146 @@
     QGraphicsScene* m_scene;
     QGraphicsWebView* m_item;
+    WebPage* m_page;
 };