Changeset 49756 in webkit

Timestamp:

Oct 18, 2009 12:55:49 PM (15 years ago)

Author:

eric@webkit.org

Message:

2009-10-18 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

Use v8::Integer::NewFromUnsigned when converting unsigneds into V8's numbers.
That is notably faster for small numbers (most common case).
​https://bugs.webkit.org/show_bug.cgi?id=30493

• bindings/scripts/CodeGeneratorV8.pm:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorV8.pm (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-10-18  Anton Muhin  <antonm@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        Use v8::Integer::NewFromUnsigned when converting unsigneds into V8's numbers.
+        That is notably faster for small numbers (most common case).
+        https://bugs.webkit.org/show_bug.cgi?id=30493
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+
 2009-10-18  Jan Michael Alonzo  <jmalonzo@webkit.org>
 

trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm

@@ -2123 +2123 @@
     # For all the types where we use 'int' as the representation type,
     # we use Integer::New which has a fast Smi conversion check.
-    return "return v8::Integer::New($value)" if GetNativeType($type) eq "int";
+    my $nativeType = GetNativeType($type);
+    return "return v8::Integer::New($value)" if $nativeType eq "int";
+    return "return v8::Integer::NewFromUnsigned($value)" if $nativeType eq "unsigned";
 
     return "return v8::Number::New($value)" if $codeGenerator->IsPrimitiveType($type) or $type eq "SVGPaintType";