Changeset 49975 in webkit


Ignore:
Timestamp:
Oct 23, 2009 5:02:54 AM (14 years ago)
Author:
zecke@webkit.org
Message:

[Qt] Plugins : Use window's winId() instead of the widget's.

2009-10-23 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Holger Freyther.

[Qt] Plugins : Use window's winId() instead of the widget's.

As per, https://developer.mozilla.org/en/NPN_GetValue
NPNVnetscapeWindow on Unix/X11: "Gets the browser toplevel window in which the
plug-in is displayed; returns Window".

The issue was found because NPNVNetscapeWindow winId() ends up creating
a native window resulting in flicker.

https://bugs.webkit.org/show_bug.cgi?id=30706

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::getValue):
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r49974 r49975  
     12009-10-23  Girish Ramakrishnan  <girish@forwardbias.in>
     2
     3        Reviewed by Holger Freyther.
     4
     5        [Qt] Plugins : Use window's winId() instead of the widget's.
     6
     7        As per, https://developer.mozilla.org/en/NPN_GetValue
     8        NPNVnetscapeWindow on Unix/X11: "Gets the browser toplevel window in which the
     9        plug-in is displayed; returns Window".
     10
     11        The issue was found because NPNVNetscapeWindow winId() ends up creating
     12        a native window resulting in flicker.
     13
     14        https://bugs.webkit.org/show_bug.cgi?id=30706
     15
     16        * plugins/qt/PluginViewQt.cpp:
     17        (WebCore::PluginView::getValue):
     18
    1192009-10-23  Girish Ramakrishnan  <girish@forwardbias.in>
    220
  • trunk/WebCore/plugins/qt/PluginViewQt.cpp

    r49974 r49975  
    634634        void* w = reinterpret_cast<void*>(value);
    635635        QWebPageClient* client = m_parentFrame->view()->hostWindow()->platformPageClient();
    636         *((XID *)w) = client ? client->ownerWidget()->winId() : 0;
     636        *((XID *)w) = client ? client->ownerWidget()->window()->winId() : 0;
    637637        return NPERR_NO_ERROR;
    638638    }
Note: See TracChangeset for help on using the changeset viewer.