Changeset 50015 in webkit


Ignore:
Timestamp:
Oct 23, 2009 5:40:14 PM (14 years ago)
Author:
pfeldman@chromium.org
Message:

2009-10-23 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement a Timeline panel.

https://bugs.webkit.org/show_bug.cgi?id=30725

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/Images/timelineIcon.png: Added.
  • inspector/front-end/TimelineAgent.js: (WebInspector.addItemToTimeline): (WebInspector.timelineProfilerWasStarted): (WebInspector.timelineProfilerWasStopped):
  • inspector/front-end/TimelinePanel.js: Added. (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.toolbarItemClass.get toolbarItemLabel): (WebInspector.TimelinePanel.prototype.get statusBarItems): (WebInspector.TimelinePanel.prototype.handleKeyEvent): (WebInspector.TimelinePanel.prototype.timelineWasStarted): (WebInspector.TimelinePanel.prototype.timelineWasStopped): (WebInspector.TimelinePanel.prototype.addItemToTimeline): (WebInspector.TimelinePanel.prototype._innerAddItemToTimeline): (WebInspector.TimelinePanel.prototype._toggleTimelineButton): (WebInspector.TimelinePanel.prototype.setMainViewWidth): (WebInspector.TimelinePanel.prototype.getItemTypeName): (WebInspector.TimelineRecordTreeElement): (WebInspector.TimelineRecordTreeElement.prototype.onattach):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels):
Location:
trunk/WebCore
Files:
2 added
9 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r50014 r50015  
     12009-10-23  Pavel Feldman  <pfeldman@chromium.org>
     2
     3        Reviewed by Timothy Hatcher.
     4
     5        Web Inspector: Implement a Timeline panel.
     6
     7        https://bugs.webkit.org/show_bug.cgi?id=30725
     8
     9        * WebCore.gypi:
     10        * WebCore.vcproj/WebCore.vcproj:
     11        * inspector/front-end/Images/timelineIcon.png: Added.
     12        * inspector/front-end/TimelineAgent.js:
     13        (WebInspector.addItemToTimeline):
     14        (WebInspector.timelineProfilerWasStarted):
     15        (WebInspector.timelineProfilerWasStopped):
     16        * inspector/front-end/TimelinePanel.js: Added.
     17        (WebInspector.TimelinePanel):
     18        (WebInspector.TimelinePanel.prototype.toolbarItemClass.get toolbarItemLabel):
     19        (WebInspector.TimelinePanel.prototype.get statusBarItems):
     20        (WebInspector.TimelinePanel.prototype.handleKeyEvent):
     21        (WebInspector.TimelinePanel.prototype.timelineWasStarted):
     22        (WebInspector.TimelinePanel.prototype.timelineWasStopped):
     23        (WebInspector.TimelinePanel.prototype.addItemToTimeline):
     24        (WebInspector.TimelinePanel.prototype._innerAddItemToTimeline):
     25        (WebInspector.TimelinePanel.prototype._toggleTimelineButton):
     26        (WebInspector.TimelinePanel.prototype.setMainViewWidth):
     27        (WebInspector.TimelinePanel.prototype.getItemTypeName):
     28        (WebInspector.TimelineRecordTreeElement):
     29        (WebInspector.TimelineRecordTreeElement.prototype.onattach):
     30        * inspector/front-end/WebKit.qrc:
     31        * inspector/front-end/inspector.css:
     32        * inspector/front-end/inspector.html:
     33        * inspector/front-end/inspector.js:
     34        (WebInspector._createPanels):
     35
    1362009-10-23  Joseph Pecoraro  <joepeck@webkit.org>
    237
  • trunk/WebCore/WebCore.gypi

    r50013 r50015  
    36433643            'inspector/front-end/TextPrompt.js',
    36443644            'inspector/front-end/TimelineAgent.js',
     3645            'inspector/front-end/TimelinePanel.js',
    36453646            'inspector/front-end/TopDownProfileDataGridTree.js',
    36463647            'inspector/front-end/treeoutline.js',
     
    37503751            'inspector/front-end/Images/timelineHollowPillRed.png',
    37513752            'inspector/front-end/Images/timelineHollowPillYellow.png',
     3753            'inspector/front-end/Images/timelineIcon.png',
    37523754            'inspector/front-end/Images/timelinePillBlue.png',
    37533755            'inspector/front-end/Images/timelinePillGray.png',
  • trunk/WebCore/WebCore.vcproj/WebCore.vcproj

    r50013 r50015  
    3645936459                                </File>
    3646036460                                <File
     36461                                        RelativePath="..\inspector\front-end\TimelinePanel.js"
     36462                                        >
     36463                                </File>
     36464                                <File
    3646136465                                        RelativePath="..\inspector\front-end\TopDownProfileDataGridTree.js"
    3646236466                                        >
  • trunk/WebCore/inspector/front-end/TimelineAgent.js

    r49565 r50015  
    4343
    4444WebInspector.addItemToTimeline = function(record) {
    45     // Not implemented.
     45    if (WebInspector.panels.timeline)
     46        WebInspector.panels.timeline.addItemToTimeline(record);
    4647}
    4748
    4849WebInspector.timelineProfilerWasStarted = function() {
    49     // Not implemented.
     50    if (WebInspector.panels.timeline)
     51        WebInspector.panels.timeline.timelineWasStarted();
    5052}
    5153
    5254WebInspector.timelineProfilerWasStopped = function() {
    53     // Not implemented.
     55    if (WebInspector.panels.timeline)
     56        WebInspector.panels.timeline.timelineWasStopped();
    5457}
  • trunk/WebCore/inspector/front-end/WebKit.qrc

    r49648 r50015  
    6161    <file>TextPrompt.js</file>
    6262    <file>TimelineAgent.js</file>
     63    <file>TimelinePanel.js</file>
    6364    <file>TopDownProfileDataGridTree.js</file>
    6465    <file>treeoutline.js</file>
  • trunk/WebCore/inspector/front-end/inspector.css

    r49858 r50015  
    204204}
    205205
     206.toolbar-item.timeline .toolbar-icon {
     207    background-image: url(Images/timelineIcon.png);
     208}
     209
    206210.toolbar-item.storage .toolbar-icon {
    207211    background-image: url(Images/storageIcon.png);
     
    32623266}
    32633267
     3268/* Timeline Style */
     3269
     3270#timeline-views {
     3271    position: absolute;
     3272    top: 0;
     3273    right: 0;
     3274    left: 200px;
     3275    bottom: 0;
     3276}
     3277
     3278.timeline-tree-item {
     3279    height: 18px;
     3280    padding-left: 24px;
     3281    white-space: nowrap;
     3282}
     3283
     3284.timeline-tree-item .data.dimmed {
     3285    color: rgba(0, 0, 0, 0.7);
     3286}
     3287
    32643288/* Profiler Style */
    32653289
  • trunk/WebCore/inspector/front-end/inspector.html

    r49648 r50015  
    9595    <script type="text/javascript" src="InjectedScriptAccess.js"></script>
    9696    <script type="text/javascript" src="TimelineAgent.js"></script>
     97    <script type="text/javascript" src="TimelinePanel.js"></script>
    9798    <script type="text/javascript" src="TestController.js"></script>
    9899</head>
  • trunk/WebCore/inspector/front-end/inspector.js

    r50014 r50015  
    144144            this.panels.profiles.registerProfileType(new WebInspector.CPUProfileType());
    145145        }
     146
     147        // Uncomment this when timeline is ready.
     148        // if (hiddenPanels.indexOf("timeline") === -1 && hiddenPanels.indexOf("timeline") === -1)
     149        //     this.panels.timeline = new WebInspector.TimelinePanel();
     150
    146151        if (hiddenPanels.indexOf("storage") === -1 && hiddenPanels.indexOf("databases") === -1)
    147             this.panels.storage = new WebInspector.StoragePanel();     
     152            this.panels.storage = new WebInspector.StoragePanel();
    148153    },
    149154
Note: See TracChangeset for help on using the changeset viewer.