Changeset 50030 in webkit

Timestamp:

Oct 24, 2009 3:40:17 PM (15 years ago)

Author:

eric@webkit.org

Message:

2009-10-24 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

Implements ReturnsNew hint for V8 bindings generation code.
​https://bugs.webkit.org/show_bug.cgi?id=30745

• bindings/scripts/CodeGeneratorV8.pm:
• bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertNewNodeToV8Object):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorV8.pm (modified) (1 diff)
• bindings/v8/V8DOMWrapper.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-10-24  Anton Muhin  <antonm@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        Implements ReturnsNew hint for V8 bindings generation code.
+        https://bugs.webkit.org/show_bug.cgi?id=30745
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+        * bindings/v8/V8DOMWrapper.h:
+        (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
+
 2009-10-24  Dan Bernstein  <mitz@apple.com>
 

trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm

@@ -2153 +2153 @@
     # special case for non-DOM node interfaces
     if (IsDOMNodeType($type)) {
-        return "return V8DOMWrapper::convertNodeToV8Object($value)";
+        if ($signature->extendedAttributes->{"ReturnsNew"}) {
+            return "return V8DOMWrapper::convertNewNodeToV8Object($value)";
+        } else {
+            return "return V8DOMWrapper::convertNodeToV8Object($value)";
+        }
     }
 

trunk/WebCore/bindings/v8/V8DOMWrapper.h

@@ -167 +167 @@
         static v8::Handle<v8::Value> convertDocumentToV8Object(Document*);
 
+        static v8::Handle<v8::Value> convertNewNodeToV8Object(PassRefPtr<Node> node)
+        {
+            return convertNewNodeToV8Object(node.get());
+        }
+
+        static v8::Handle<v8::Value> convertNewNodeToV8Object(Node* node)
+        {
+            return convertNewNodeToV8Object(node, 0, getDOMNodeMap());
+        }
+
         static v8::Handle<v8::Value> convertNewNodeToV8Object(Node*, V8Proxy*, DOMWrapperMap<Node>&);