Changeset 50053 in webkit


Ignore:
Timestamp:
Oct 26, 2009 4:35:25 AM (15 years ago)
Author:
eric@webkit.org
Message:

2009-10-26 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=27085
[Gtk] Incorrect rendering of list

Adds a way for platforms to indicate that a particular object
should not be ignored.

  • accessibility/AccessibilityObject.h:
  • accessibility/chromium/AccessibilityObjectChromium.cpp:
  • accessibility/gtk/AccessibilityObjectAtk.cpp:
  • accessibility/mac/AccessibilityObjectMac.mm:
  • accessibility/qt/AccessibilityObjectQt.cpp:
  • accessibility/win/AccessibilityObjectWin.cpp:
  • accessibility/wx/AccessibilityObjectWx.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
  • accessibility/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::accessibilityIsIgnored):
Location:
trunk/WebCore
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r50051 r50053  
     12009-10-26  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
     2
     3        Reviewed by Xan Lopez.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=27085
     6        [Gtk] Incorrect rendering of list
     7
     8        Adds a way for platforms to indicate that a particular object
     9        should not be ignored.
     10
     11        * accessibility/AccessibilityObject.h:
     12        * accessibility/chromium/AccessibilityObjectChromium.cpp:
     13        * accessibility/gtk/AccessibilityObjectAtk.cpp:
     14        * accessibility/mac/AccessibilityObjectMac.mm:
     15        * accessibility/qt/AccessibilityObjectQt.cpp:
     16        * accessibility/win/AccessibilityObjectWin.cpp:
     17        * accessibility/wx/AccessibilityObjectWx.cpp:
     18        (AccessibilityObject::accessibilityPlatformIncludesObject):
     19        * accessibility/AccessibilityRenderObject.cpp:
     20        (AccessibilityRenderObject::accessibilityIsIgnored):
     21
    1222009-10-26  Kinuko Yasuda  <kinuko@google.com>
    223

  • trunk/WebCore/accessibility/AccessibilityObject.h

    r48482 r50053  
    460460#endif
    461461
     462    // gives platforms the opportunity to indicate that an object shouldn't be ignored
     463#if HAVE(ACCESSIBILITY)
     464    bool accessibilityPlatformIncludesObject() const;
     465#else
     466    bool accessibilityPlatformIncludesObject() const { return false; }
     467#endif
     468
    462469    // allows for an AccessibilityObject to update its render tree or perform
    463470    // other operations update type operations

  • trunk/WebCore/accessibility/AccessibilityRenderObject.cpp

    r49958 r50053  
    12591259bool AccessibilityRenderObject::accessibilityIsIgnored() const
    12601260{
     1261    // is the platform is interested in this object?
     1262    if (accessibilityPlatformIncludesObject())
     1263        return false;
     1264
    12611265    // ignore invisible element
    12621266    if (!m_renderer || m_renderer->style()->visibility() != VISIBLE)

  • trunk/WebCore/accessibility/chromium/AccessibilityObjectChromium.cpp

    r43833 r50053  
    3535}
    3636
     37bool AccessibilityObject::accessibilityPlatformIncludesObject() const
     38{
     39    return false;
     40}
     41
    3742} // namespace WebCore

  • trunk/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp

    r43833 r50053  
    3333}
    3434
     35bool AccessibilityObject::accessibilityPlatformIncludesObject() const
     36{
     37    // When a list item is made up entirely of children (e.g. paragraphs)
     38    // the list item gets ignored. We need it.
     39    if (isGroup()) {
     40        AccessibilityObject* parent = parentObject();
     41        if (parent && parent->isList())
     42            return true;
     43    }
     44
     45    return false;
     46}
     47
    3548AccessibilityObjectWrapper* AccessibilityObject::wrapper() const
    3649{

  • trunk/WebCore/accessibility/mac/AccessibilityObjectMac.mm

    r44678 r50053  
    4141    return [attachment accessibilityIsIgnored];
    4242}
     43
     44bool AccessibilityObject::accessibilityPlatformIncludesObject() const
     45{
     46    return false;
     47}
    4348   
    4449} // WebCore

  • trunk/WebCore/accessibility/qt/AccessibilityObjectQt.cpp

    r43833 r50053  
    3030}
    3131
     32bool AccessibilityObject::accessibilityPlatformIncludesObject() const
     33{
     34    return false;
     35}
     36
    3237} // namespace WebCore
    3338

  • trunk/WebCore/accessibility/win/AccessibilityObjectWin.cpp

    r43833 r50053  
    3636}
    3737
     38bool AccessibilityObject::accessibilityPlatformIncludesObject() const
     39{
     40    return false;
     41}
     42
    3843} // namespace WebCore
    3944

  • trunk/WebCore/accessibility/wx/AccessibilityObjectWx.cpp

    r43833 r50053  
    3030}
    3131
     32bool AccessibilityObject::accessibilityPlatformIncludesObject() const
     33{
     34    return false;
     35}
     36
    3237} // namespace WebCore
    3338
Note: See TracChangeset for help on using the changeset viewer.