Changeset 50084 in webkit


Ignore:
Timestamp:
Oct 26, 2009 12:30:58 PM (15 years ago)
Author:
eric@webkit.org
Message:

2009-10-26 Keishi Hattori <​casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

console.assert should prefix messages with "Assertion failed: "
​https://bugs.webkit.org/show_bug.cgi?id=19135

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype.toMessageElement): Append "Assertion failed: " for AssertMessageType. (WebInspector.ConsoleMessage.prototype.toString):
  • page/Console.cpp: (WebCore::Console::assertCondition): Use AssertMessageType.
  • page/Console.h: (WebCore::MessageType): Added AssertMessageType.
Location:
trunk/WebCore
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r50083 r50084  
     12009-10-26  Keishi Hattori  <casey.hattori@gmail.com>
     2
     3        Reviewed by Timothy Hatcher.
     4
     5        console.assert should prefix messages with "Assertion failed: "
     6        https://bugs.webkit.org/show_bug.cgi?id=19135
     7
     8        * English.lproj/localizedStrings.js:
     9        * inspector/front-end/ConsoleView.js:
     10        (WebInspector.ConsoleMessage.prototype.toMessageElement): Append "Assertion failed: " for AssertMessageType.
     11        (WebInspector.ConsoleMessage.prototype.toString):
     12        * page/Console.cpp:
     13        (WebCore::Console::assertCondition): Use AssertMessageType.
     14        * page/Console.h:
     15        (WebCore::MessageType): Added AssertMessageType.
     16
    1172009-10-26  Rahul Kuchhal  <kuchhal@chromium.org>
    218

  • trunk/WebCore/inspector/front-end/ConsoleView.js

    r50064 r50084  
    790790        var messageTextElement = document.createElement("span");
    791791        messageTextElement.className = "console-message-text";
     792        if (this.type === WebInspector.ConsoleMessage.MessageType.Assert)
     793            messageTextElement.appendChild(document.createTextNode(WebInspector.UIString("Assertion failed: ")));
    792794        messageTextElement.appendChild(this.formattedMessage);
    793795        element.appendChild(messageTextElement);
    … …  
    850852            case WebInspector.ConsoleMessage.MessageType.EndGroup:
    851853                typeString = "End Group";
     854                break;
     855            case WebInspector.ConsoleMessage.MessageType.Assert:
     856                typeString = "Assert";
    852857                break;
    853858        }
    … …  
    906911    Trace: 2,
    907912    StartGroup: 3,
    908     EndGroup: 4
     913    EndGroup: 4,
     914    Assert: 5
    909915}
    910916

  • trunk/WebCore/page/Console.cpp

    r49976 r50084  
    249249        return;
    250250
    251     // FIXME: <https://bugs.webkit.org/show_bug.cgi?id=19135> It would be nice to prefix assertion failures with a message like "Assertion failed: ".
    252     addMessage(LogMessageType, ErrorMessageLevel, callStack, true);
     251    addMessage(AssertMessageType, ErrorMessageLevel, callStack, true);
    253252}
    254253

  • trunk/WebCore/page/Console.h

    r47952 r50084  
    6565        TraceMessageType,
    6666        StartGroupMessageType,
    67         EndGroupMessageType
     67        EndGroupMessageType,
     68        AssertMessageType
    6869    };
    6970
Note: See TracChangeset for help on using the changeset viewer.