Changeset 50132 in webkit

Timestamp:

Oct 27, 2009 12:12:10 AM (15 years ago)

Author:

dbates@webkit.org

Message:

2009-10-26 Daniel Bates <​dbates@webkit.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=30491

Fixes an issue where pressing return/enter on the keyboard
in <isindex> does not submit it if is not within a <form>.

According to the HTML 2.0 thru HTML 4.01 spec
(​http://www.w3.org/MarkUp/html-spec/html-spec_7.html#SEC7.5), the
<isindex> element does not need to be within a <form> element in
order to submit it. It can submitted on its own. Also, if present,
the href property of the <base> element will dictate where to submit
the value of the <isindex> element (this is analogous to the action
property of the <form> element).

Tests: http/tests/misc/isindex-with-no-form-base-href.html

http/tests/misc/isindex-with-no-form.html

• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Calls createTemporaryFormForIsIndex() to create a <form> if none is present and we are an <isindex> element. (WebCore::HTMLInputElement::createTemporaryFormForIsIndex): Added.
• html/HTMLInputElement.h:

2009-10-26 Daniel Bates <​dbates@webkit.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=30491

Test that the <isindex> element can be submitted without being enclosed
within a <form> element. Also tests that the href property of the <base>
element can be used to direct where the submission is sent.

• http/tests/misc/isindex-with-no-form-base-href-expected.txt: Added.
• http/tests/misc/isindex-with-no-form-base-href.html: Added.
• http/tests/misc/isindex-with-no-form-expected.txt: Added.
• http/tests/misc/isindex-with-no-form.html: Added.
• http/tests/misc/resources/isindex-with-no-form-base-href-submit.html: Added.
• http/tests/misc/resources/isindex-with-no-form-base-href.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/tests/misc/isindex-with-no-form-base-href-expected.txt (added)
• LayoutTests/http/tests/misc/isindex-with-no-form-base-href.html (added)
• LayoutTests/http/tests/misc/isindex-with-no-form-expected.txt (added)
• LayoutTests/http/tests/misc/isindex-with-no-form.html (added)
• LayoutTests/http/tests/misc/resources/isindex-with-no-form-base-href-submit.html (added)
• LayoutTests/http/tests/misc/resources/isindex-with-no-form-base-href.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLInputElement.cpp (modified) (2 diffs)
• WebCore/html/HTMLInputElement.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-10-26  Daniel Bates  <dbates@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        https://bugs.webkit.org/show_bug.cgi?id=30491
+
+        Test that the <isindex> element can be submitted without being enclosed
+        within a <form> element. Also tests that the href property of the <base>
+        element can be used to direct where the submission is sent.
+
+        * http/tests/misc/isindex-with-no-form-base-href-expected.txt: Added.
+        * http/tests/misc/isindex-with-no-form-base-href.html: Added.
+        * http/tests/misc/isindex-with-no-form-expected.txt: Added.
+        * http/tests/misc/isindex-with-no-form.html: Added.
+        * http/tests/misc/resources/isindex-with-no-form-base-href-submit.html: Added.
+        * http/tests/misc/resources/isindex-with-no-form-base-href.html: Added.
+
 2009-10-26  Brian Weinstein  <bweinstein@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-10-26  Daniel Bates  <dbates@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        https://bugs.webkit.org/show_bug.cgi?id=30491
+
+        Fixes an issue where pressing return/enter on the keyboard 
+        in <isindex> does not submit it if is not within a <form>.
+
+        According to the HTML 2.0 thru HTML 4.01 spec 
+        (http://www.w3.org/MarkUp/html-spec/html-spec_7.html#SEC7.5), the 
+        <isindex> element does not need to be within a <form> element in 
+        order to submit it. It can submitted on its own. Also, if present,
+        the href property of the <base> element will dictate where to submit
+        the value of the <isindex> element (this is analogous to the action 
+        property of the <form> element).
+
+        Tests: http/tests/misc/isindex-with-no-form-base-href.html
+               http/tests/misc/isindex-with-no-form.html
+
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::defaultEventHandler): Calls createTemporaryFormForIsIndex()
+        to create a <form> if none is present and we are an <isindex> element.
+        (WebCore::HTMLInputElement::createTemporaryFormForIsIndex): Added.
+        * html/HTMLInputElement.h:
+
 2009-10-26  Oliver Hunt  <oliver@apple.com>
 

trunk/WebCore/html/HTMLInputElement.cpp

@@ -1550 +1550 @@
                 toRenderTextControl(r)->setEdited(false);
         }
-        // Form may never have been present, or may have been destroyed by the change event.
-        if (form())
-            form()->submitClick(evt);
+
+        RefPtr<HTMLFormElement> formForSubmission = form();
+        // If there is no form and the element is an <isindex>, then create a temporary form just to be used for submission.
+        if (!formForSubmission && inputType() == ISINDEX)
+            formForSubmission = createTemporaryFormForIsIndex();
+
+        // Form may never have been present, or may have been destroyed by code responding to the change event.
+        if (formForSubmission)
+            formForSubmission->submitClick(evt);
+
         evt->setDefaultHandled();
         return;
@@ -1568 +1575 @@
     if (!callBaseClassEarly && !evt->defaultHandled())
         HTMLFormControlElementWithState::defaultEventHandler(evt);
+}
+
+PassRefPtr<HTMLFormElement> HTMLInputElement::createTemporaryFormForIsIndex()
+{
+    RefPtr<HTMLFormElement> form = new HTMLFormElement(formTag, document());
+    form->registerFormElement(this);
+    form->setMethod("GET");
+    if (!document()->baseURL().isEmpty()) {
+        // We treat the href property of the <base> element as the form action, as per section 7.5 
+        // "Queries and Indexes" of the HTML 2.0 spec. <http://www.w3.org/MarkUp/html-spec/html-spec_7.html#SEC7.5>.
+        form->setAction(document()->baseURL().string());
+    }
+    return form.release();
 }
 

trunk/WebCore/html/HTMLInputElement.h

@@ -257 +257 @@
     virtual bool isRequiredFormControl() const;
 
+    PassRefPtr<HTMLFormElement> createTemporaryFormForIsIndex();
+
 #if ENABLE(DATALIST)
     HTMLDataListElement* dataList() const;