Changeset 50446 in webkit


Ignore:
Timestamp:
Nov 3, 2009 2:00:20 AM (14 years ago)
Author:
eric@webkit.org
Message:

2009-11-02 Chris Fleizach <Chris Fleizach>

Reviewed by David Levin.

fix accessibility webkit-style-check errors
​https://bugs.webkit.org/show_bug.cgi?id=29672

  • accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::getOrCreate): (WebCore::AXObjectCache::remove): (WebCore::AXObjectCache::platformGenerateAXID): (WebCore::AXObjectCache::removeAXID):
  • accessibility/AXObjectCache.h: (WebCore::AXObjectCache::enableAccessibility): (WebCore::AXObjectCache::enableEnhancedUserInterfaceAccessibility): (WebCore::AXObjectCache::accessibilityEnabled): (WebCore::AXObjectCache::accessibilityEnhancedUserInterfaceEnabled): (WebCore::AXObjectCache::isIDinUse): (WebCore::AXObjectCache::objectFromAXID): (WebCore::AXObjectCache::): (WebCore::AXObjectCache::handleActiveDescendantChanged): (WebCore::AXObjectCache::handleAriaRoleChanged): (WebCore::AXObjectCache::detachWrapper): (WebCore::AXObjectCache::attachWrapper): (WebCore::AXObjectCache::selectedChildrenChanged): (WebCore::AXObjectCache::postNotification): (WebCore::AXObjectCache::postPlatformNotification): (WebCore::AXObjectCache::handleFocusedUIElementChanged): (WebCore::AXObjectCache::handleScrolledToAnchor):
  • accessibility/AccessibilityARIAGrid.cpp: (WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
  • accessibility/AccessibilityAllInOne.cpp:
  • accessibility/AccessibilityImageMapLink.cpp:
  • accessibility/AccessibilityList.h: (WebCore::AccessibilityList::isList):
  • accessibility/AccessibilityListBox.cpp:
  • accessibility/AccessibilityListBox.h: (WebCore::AccessibilityListBox::isListBox):
  • accessibility/AccessibilityListBoxOption.cpp:
  • accessibility/AccessibilityListBoxOption.h: (WebCore::AccessibilityListBoxOption::isListBoxOption):
  • accessibility/AccessibilityMediaControls.h: (WebCore::AccessibilityMediaControl::~AccessibilityMediaControl): (WebCore::AccessibilityMediaTimeline::~AccessibilityMediaTimeline): (WebCore::AccessibilityMediaTimeline::isMediaTimeline): (WebCore::AccessibilityMediaControlsContainer::~AccessibilityMediaControlsContainer): (WebCore::AccessibilityMediaControlsContainer::roleValue): (WebCore::AccessibilityMediaControlsContainer::accessibilityIsIgnored): (WebCore::AccessibilityMediaTimeDisplay::~AccessibilityMediaTimeDisplay): (WebCore::AccessibilityMediaTimeDisplay::roleValue):
  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::parentObjectUnignored): (WebCore::AccessibilityObject::rightLineVisiblePositionRange): (WebCore::replacedNodeNeedsCharacter): (WebCore::AccessibilityObject::stringForVisiblePositionRange): (WebCore::AccessibilityObject::lengthForVisiblePositionRange): (WebCore::AccessibilityObject::actionVerb):
  • accessibility/AccessibilityObject.h: (WebCore::PlainTextRange::isNull): (WebCore::AccessibilityObject::isAccessibilityRenderObject): (WebCore::AccessibilityObject::isAnchor): (WebCore::AccessibilityObject::isAttachment): (WebCore::AccessibilityObject::isHeading): (WebCore::AccessibilityObject::isLink): (WebCore::AccessibilityObject::isImage): (WebCore::AccessibilityObject::isNativeImage): (WebCore::AccessibilityObject::isImageButton): (WebCore::AccessibilityObject::isPasswordField): (WebCore::AccessibilityObject::isTextControl): (WebCore::AccessibilityObject::isNativeTextControl): (WebCore::AccessibilityObject::isWebArea): (WebCore::AccessibilityObject::isCheckboxOrRadio): (WebCore::AccessibilityObject::isListBox): (WebCore::AccessibilityObject::isFileUploadButton): (WebCore::AccessibilityObject::isProgressIndicator): (WebCore::AccessibilityObject::isSlider): (WebCore::AccessibilityObject::isControl): (WebCore::AccessibilityObject::isList): (WebCore::AccessibilityObject::isDataTable): (WebCore::AccessibilityObject::isTableRow): (WebCore::AccessibilityObject::isTableColumn): (WebCore::AccessibilityObject::isTableCell): (WebCore::AccessibilityObject::isFieldset): (WebCore::AccessibilityObject::isGroup): (WebCore::AccessibilityObject::isChecked): (WebCore::AccessibilityObject::isEnabled): (WebCore::AccessibilityObject::isSelected): (WebCore::AccessibilityObject::isFocused): (WebCore::AccessibilityObject::isHovered): (WebCore::AccessibilityObject::isIndeterminate): (WebCore::AccessibilityObject::isLoaded): (WebCore::AccessibilityObject::isMultiSelect): (WebCore::AccessibilityObject::isOffScreen): (WebCore::AccessibilityObject::isPressed): (WebCore::AccessibilityObject::isReadOnly): (WebCore::AccessibilityObject::isVisited): (WebCore::AccessibilityObject::isRequired): (WebCore::AccessibilityObject::canSetFocusAttribute): (WebCore::AccessibilityObject::canSetTextRangeAttributes): (WebCore::AccessibilityObject::canSetValueAttribute): (WebCore::AccessibilityObject::hasIntValue): (WebCore::AccessibilityObject::accessibilityShouldUseUniqueId): (WebCore::AccessibilityObject::accessibilityIsIgnored):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::parentObjectIfExists): (WebCore::AccessibilityRenderObject::parentObject): (WebCore::AccessibilityRenderObject::isMenuRelated): (WebCore::AccessibilityRenderObject::accessibilityDescription): (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): (WebCore::AccessibilityRenderObject::isFocused): (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine): (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange): (WebCore::AccessibilityRenderObject::doAXRangeForLine): (WebCore::AccessibilityRenderObject::doAXStringForRange): (WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest): (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute): (WebCore::AccessibilityRenderObject::determineAccessibilityRole): (WebCore::AccessibilityRenderObject::isPresentationalChildOfAriaRole): (WebCore::AccessibilityRenderObject::canSetFocusAttribute): (WebCore::AccessibilityRenderObject::canHaveChildren): (WebCore::AccessibilityRenderObject::actionVerb): (WebCore::shouldReturnTagNameAsRoleForMSAA):
  • accessibility/AccessibilityRenderObject.h: (WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):
  • accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySlider::orientation):
  • accessibility/AccessibilitySlider.h: (WebCore::AccessibilitySlider::~AccessibilitySlider): (WebCore::AccessibilitySlider::roleValue): (WebCore::AccessibilitySlider::accessibilityIsIgnored): (WebCore::AccessibilitySlider::isSlider): (WebCore::AccessibilitySlider::canSetValueAttribute): (WebCore::AccessibilitySliderThumb::~AccessibilitySliderThumb): (WebCore::AccessibilitySliderThumb::roleValue): (WebCore::AccessibilitySliderThumb::accessibilityIsIgnored): (WebCore::AccessibilitySliderThumb::setParentObject): (WebCore::AccessibilitySliderThumb::parentObject):
  • accessibility/AccessibilityTable.cpp: (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
  • accessibility/AccessibilityTableColumn.cpp:
  • accessibility/AccessibilityTableHeaderContainer.cpp: (WebCore::AccessibilityTableHeaderContainer::addChildren):
  • accessibility/AccessibilityTableRow.cpp:
  • accessibility/mac/AccessibilityObjectWrapper.h:
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r50444 r50446  
    877877
    8788782009-11-01  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
     879
     880        Reviewed by Jan Alonzo.
     881
     882        https://bugs.webkit.org/show_bug.cgi?id=30964
     883        [Gtk] Implemment AtkDocument
     884
     885        Provides access to expected document attributes.
     886
     887        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
     888        (documentAttributeValue):
     889        (webkit_accessible_document_get_document_attribute_value):
     890        (webkit_accessible_document_get_document_attributes):
     891
     8922009-11-03  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
    879893
    880894        Reviewed by Jan Alonzo.

  • trunk/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp

    r50412 r50446  
    4545#include "CString.h"
    4646#include "Document.h"
     47#include "DocumentType.h"
    4748#include "Editor.h"
    4849#include "Frame.h"
    … …  
    14121413}
    14131414
     1415static const gchar* documentAttributeValue(AtkDocument* document, const gchar* attribute)
     1416{
     1417    Document* coreDocument = core(document)->document();
     1418    if (!coreDocument)
     1419        return 0;
     1420
     1421    String value = String();
     1422    if (!g_ascii_strcasecmp(attribute, "DocType") && coreDocument->doctype())
     1423        value = coreDocument->doctype()->name();
     1424    else if (!g_ascii_strcasecmp(attribute, "Encoding"))
     1425        value = coreDocument->charset();
     1426    else if (!g_ascii_strcasecmp(attribute, "URI"))
     1427        value = coreDocument->documentURI();
     1428    if (!value.isEmpty())
     1429        return returnString(value);
     1430
     1431    return 0;
     1432}
     1433
    14141434static const gchar* webkit_accessible_document_get_attribute_value(AtkDocument* document, const gchar* attribute)
    14151435{
    1416     // FIXME: This needs to be implemented.
    1417     notImplemented();
    1418     return 0;
     1436    return documentAttributeValue(document, attribute);
    14191437}
    14201438
    14211439static AtkAttributeSet* webkit_accessible_document_get_attributes(AtkDocument* document)
    14221440{
    1423     // FIXME: This needs to be implemented.
    1424     notImplemented();
    1425     return 0;
     1441    AtkAttributeSet* attributeSet = 0;
     1442    const gchar* attributes [] = {"DocType", "Encoding", "URI"};
     1443
     1444    for (unsigned i = 0; i < G_N_ELEMENTS(attributes); i++) {
     1445        const gchar* value = documentAttributeValue(document, attributes[i]);
     1446        if (value)
     1447            attributeSet = addAttributeToSet(attributeSet, attributes[i], value);
     1448    }
     1449
     1450    return attributeSet;
    14261451}
    14271452
Note: See TracChangeset for help on using the changeset viewer.