Changeset 50637 in webkit

Timestamp:

Nov 8, 2009 9:52:39 PM (14 years ago)

Author:

eric@webkit.org

Message:

2009-11-08 Johnny Ding <​johnnyding.webkit@gmail.com>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=31224
[V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.

• fast/dom/StyleSheet/get-stylesheet-byname-expected.txt: Added.
• fast/dom/StyleSheet/get-stylesheet-byname.html: Added.
• fast/dom/StyleSheet/script-tests: Added.
• fast/dom/StyleSheet/script-tests/get-stylesheet-byname.js: Added.

2009-11-08 Johnny Ding <​johnnyding.webkit@gmail.com>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=31224
[V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.

Test: fast/dom/StyleSheet/get-stylesheet-byname.html

• bindings/v8/custom/V8StyleSheetListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/StyleSheet/get-stylesheet-byname-expected.txt (added)
• LayoutTests/fast/dom/StyleSheet/get-stylesheet-byname.html (added)
• LayoutTests/fast/dom/StyleSheet/script-tests (added)
• LayoutTests/fast/dom/StyleSheet/script-tests/get-stylesheet-byname.js (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/bindings/v8/custom/V8StyleSheetListCustom.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-11-08  Johnny Ding  <johnnyding.webkit@gmail.com>
+
+        Reviewed by Dimitri Glazkov.
+
+        https://bugs.webkit.org/show_bug.cgi?id=31224
+        [V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.
+
+        * fast/dom/StyleSheet/get-stylesheet-byname-expected.txt: Added.
+        * fast/dom/StyleSheet/get-stylesheet-byname.html: Added.
+        * fast/dom/StyleSheet/script-tests: Added.
+        * fast/dom/StyleSheet/script-tests/get-stylesheet-byname.js: Added.
+
 2009-11-08  Daniel Bates  <dbates@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-11-08  Johnny Ding  <johnnyding.webkit@gmail.com>
+
+        Reviewed by Dimitri Glazkov.
+
+        https://bugs.webkit.org/show_bug.cgi?id=31224
+        [V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.
+
+        Test: fast/dom/StyleSheet/get-stylesheet-byname.html
+
+        * bindings/v8/custom/V8StyleSheetListCustom.cpp:
+        (WebCore::NAMED_PROPERTY_GETTER):
+
 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
 

trunk/WebCore/bindings/v8/custom/V8StyleSheetListCustom.cpp

@@ -30 +30 @@
 
 #include "config.h"
+#include "HTMLStyleElement.h"
 #include "StyleSheetList.h"
 
@@ -51 +52 @@
         return notHandledByInterceptor();
 
-    return V8DOMWrapper::convertToV8Object(V8ClassIndex::HTMLSTYLEELEMENT, item);
+    return V8DOMWrapper::convertToV8Object(V8ClassIndex::STYLESHEET, item->sheet());
 }